]> www.pilppa.org Git - linux-2.6-omap-h63xx.git/commitdiff
SDRC: prevent null pointer dereference if sdrc_init_params is null
authorPaul Walmsley <paul@pwsan.com>
Tue, 24 Mar 2009 00:41:53 +0000 (00:41 +0000)
committerTony Lindgren <tony@atomide.com>
Wed, 25 Mar 2009 00:35:13 +0000 (17:35 -0700)
omap2_sdrc_get_params() should check to see if a board-*.c file has
called omap2_init_common_hw() with a null pointer for the
omap_sdrc_params argument, rather than attempting to dereference it.
Otherwise, boot will fail after the "Reprogramming SDRC" boot message.
Problem found by Peter Barada <peterb@logicpd.com>.

Signed-off-by: Paul Walmsley <paul@pwsan.com>
Tested-by: Peter Barada <peterb@logicpd.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
arch/arm/mach-omap2/sdrc.c

index 7da65879bccd25a7f2c40a27287cede8f83d9661..993fd253cb9cb4bca12e7348210e1715ed6b9d67 100644 (file)
@@ -56,6 +56,9 @@ struct omap_sdrc_params *omap2_sdrc_get_params(unsigned long r)
 {
        struct omap_sdrc_params *sp;
 
+       if (!sdrc_init_params)
+               return NULL;
+
        sp = sdrc_init_params;
 
        while (sp->rate && sp->rate != r)