]> www.pilppa.org Git - linux-2.6-omap-h63xx.git/commitdiff
netfilter: xt_TCPOPTSTRIP: signed tcphoff for ipv6_skip_exthdr() retval
authorRoel Kluin <12o3l@tiscali.nl>
Tue, 29 Apr 2008 10:15:10 +0000 (03:15 -0700)
committerDavid S. Miller <davem@davemloft.net>
Tue, 29 Apr 2008 10:15:10 +0000 (03:15 -0700)
if tcphoff remains unsigned, a negative ipv6_skip_exthdr() return value will
go unnoticed,

Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/netfilter/xt_TCPOPTSTRIP.c

index 3b2aa56833b9072d7e107d55796d62dae53935fe..9685b6fcbc81b60fb01a5cd7d8a3c6ac5e368024 100644 (file)
@@ -90,7 +90,7 @@ tcpoptstrip_tg6(struct sk_buff *skb, const struct net_device *in,
                const struct xt_target *target, const void *targinfo)
 {
        struct ipv6hdr *ipv6h = ipv6_hdr(skb);
-       unsigned int tcphoff;
+       int tcphoff;
        u_int8_t nexthdr;
 
        nexthdr = ipv6h->nexthdr;