]> www.pilppa.org Git - linux-2.6-omap-h63xx.git/commitdiff
wireless, wavelan: spin off by 1
authorRoel Kluin <roel.kluin@gmail.com>
Wed, 25 Feb 2009 12:35:34 +0000 (13:35 +0100)
committerJohn W. Linville <linville@tuxdriver.com>
Thu, 5 Mar 2009 19:39:31 +0000 (14:39 -0500)
spin can reach -1 after the loop, so 0 is still success.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/wavelan_cs.c

index de717f8ffd61061a5caccfa92cb62d70403b1087..1565a0a609739aa0f997cb7621af8d8528a8fd3e 100644 (file)
@@ -838,9 +838,8 @@ wv_82593_cmd(struct net_device *    dev,
     }
   while(((status & SR3_EXEC_STATE_MASK) != SR3_EXEC_IDLE) && (spin-- > 0));
 
-  /* If the interrupt hasn't be posted */
-  if(spin <= 0)
-    {
+  /* If the interrupt hasn't been posted */
+  if (spin < 0) {
 #ifdef DEBUG_INTERRUPT_ERROR
       printk(KERN_INFO "wv_82593_cmd: %s timeout (previous command), status 0x%02x\n",
             str, status);