]> www.pilppa.org Git - linux-2.6-omap-h63xx.git/commitdiff
[MTD] [NAND] fsl_elbc_nand: fix section mismatch between probe and remove
authorAnton Vorontsov <avorontsov@ru.mvista.com>
Fri, 6 Jun 2008 14:59:40 +0000 (18:59 +0400)
committerDavid Woodhouse <dwmw2@infradead.org>
Sat, 7 Jun 2008 07:36:19 +0000 (08:36 +0100)
WARNING: drivers/mtd/nand/built-in.o(.devinit.text+0x114): Section mismatch
in reference from the function fsl_elbc_ctrl_probe() to the function
.devexit.text:fsl_elbc_ctrl_remove()

__devinit functions should not call functions with __devexit. Since probe
function calls remove in case of errors, we want to remove __devexit
attribute from it.

Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
Acked-by: Scott Wood <scottwood@freescale.com>
Signed-off-by: David Woodhouse <dwmw2@infradead.org>
drivers/mtd/nand/fsl_elbc_nand.c

index 4b69aacdf5ca45410207dca1f8908413f166e1c1..1b06d29dd06b7ed5fcf75b92160b3e7f08f626e5 100644 (file)
@@ -917,7 +917,7 @@ static int __devinit fsl_elbc_ctrl_init(struct fsl_elbc_ctrl *ctrl)
        return 0;
 }
 
-static int __devexit fsl_elbc_ctrl_remove(struct of_device *ofdev)
+static int fsl_elbc_ctrl_remove(struct of_device *ofdev)
 {
        struct fsl_elbc_ctrl *ctrl = dev_get_drvdata(&ofdev->dev);
        int i;
@@ -1041,7 +1041,7 @@ static struct of_platform_driver fsl_elbc_ctrl_driver = {
        },
        .match_table = fsl_elbc_match,
        .probe = fsl_elbc_ctrl_probe,
-       .remove = __devexit_p(fsl_elbc_ctrl_remove),
+       .remove = fsl_elbc_ctrl_remove,
 };
 
 static int __init fsl_elbc_init(void)