]> www.pilppa.org Git - linux-2.6-omap-h63xx.git/commitdiff
ftrace: remove packed attribute on ftrace_page.
authorDavid Miller <davem@davemloft.net>
Wed, 14 May 2008 05:06:56 +0000 (22:06 -0700)
committerThomas Gleixner <tglx@linutronix.de>
Fri, 23 May 2008 20:35:57 +0000 (22:35 +0200)
It causes unaligned access traps on platforms like sparc
(ftrace_page may be marked packed, but once we return
a dyn_ftrace sub-object from this array to another piece
of code, the "packed" part of the typing information doesn't
propagate).

But also, it didn't serve any purpose either.  Even if packed,
on 64-bit or 32-bit, it didn't give us any more dyn_ftrace
entries per-page.

Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
kernel/trace/ftrace.c

index af5ad8949abb58a72975d4237b5120145c73c439..07b2a14943f8b3ee39d3487ae731e799c6d120e9 100644 (file)
@@ -177,9 +177,9 @@ static DEFINE_MUTEX(ftrace_filter_lock);
 
 struct ftrace_page {
        struct ftrace_page      *next;
-       int                     index;
+       unsigned long           index;
        struct dyn_ftrace       records[];
-} __attribute__((packed));
+};
 
 #define ENTRIES_PER_PAGE \
   ((PAGE_SIZE - sizeof(struct ftrace_page)) / sizeof(struct dyn_ftrace))