]> www.pilppa.org Git - linux-2.6-omap-h63xx.git/commitdiff
USB: usbtest.c: length, sglen and vary are unsigned, so cannot be negative
authorroel kluin <roel.kluin@gmail.com>
Tue, 21 Oct 2008 04:36:44 +0000 (00:36 -0400)
committerGreg Kroah-Hartman <gregkh@suse.de>
Wed, 22 Oct 2008 17:05:28 +0000 (10:05 -0700)
length, sglen and vary are unsigned, so cannot be negative

see
vi drivers/usb/misc/usbtest.c +18
struct usbtest_param {
...
        unsigned                iterations;
        unsigned                length;
        unsigned                vary;
        unsigned                sglen;
...
};

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/usb/misc/usbtest.c

index b358c4e1cf212f114bbad89416f358c244311bc3..444c69c447bec115e4757446b6ad8a34ae42816c 100644 (file)
@@ -1561,8 +1561,7 @@ usbtest_ioctl (struct usb_interface *intf, unsigned int code, void *buf)
        if (code != USBTEST_REQUEST)
                return -EOPNOTSUPP;
 
-       if (param->iterations <= 0 || param->length < 0
-                       || param->sglen < 0 || param->vary < 0)
+       if (param->iterations <= 0)
                return -EINVAL;
 
        if (mutex_lock_interruptible(&dev->lock))