]> www.pilppa.org Git - linux-2.6-omap-h63xx.git/commitdiff
generic-ipi: powerpc/generic-ipi tree build failure
authorStephen Rothwell <sfr@canb.auug.org.au>
Mon, 14 Jul 2008 09:55:03 +0000 (19:55 +1000)
committerIngo Molnar <mingo@elte.hu>
Mon, 14 Jul 2008 15:54:22 +0000 (17:54 +0200)
Today's linux-next build (powerpc allmodconfig) failed like this:

ERROR: ".save_stack_trace" [tests/backtracetest.ko] undefined!

But save_stack_trace is exported in arch/powerpc/kernel/stacktrace.c

I couldn't figure it out until I noticed these earlier warnings:

arch/powerpc/kernel/stacktrace.c:47: warning: data definition has no type or storage class
arch/powerpc/kernel/stacktrace.c:47: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
arch/powerpc/kernel/stacktrace.c:47: warning: parameter names (without types) in function declaration

I applied the patch below.

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: <linuxppc-dev@ozlabs.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
arch/powerpc/kernel/stacktrace.c

index 9861f17258dac2e386d4ac1eacd1e6ed09c78d43..3cf0d94ba3408c8a93dbd16ddfb4789579cde119 100644 (file)
@@ -12,6 +12,7 @@
 
 #include <linux/sched.h>
 #include <linux/stacktrace.h>
+#include <linux/module.h>
 #include <asm/ptrace.h>
 
 /*