]> www.pilppa.org Git - linux-2.6-omap-h63xx.git/commitdiff
[SCSI] sym53c8xx: Don't disable interrupts in the interrupt handler
authorMatthew Wilcox <matthew@wil.cx>
Fri, 5 Oct 2007 19:55:02 +0000 (15:55 -0400)
committerJames Bottomley <jejb@mulgrave.localdomain>
Tue, 23 Oct 2007 19:09:27 +0000 (15:09 -0400)
Interrupts can't be re-entered, so it's sufficient to call spin_lock, not
spin_lock_irqsave().

Signed-off-by: Matthew Wilcox <willy@linux.intel.com>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
drivers/scsi/sym53c8xx_2/sym_glue.c

index 9fc2ae836257beeb2842fbe32dfaf804fe03c2d2..b5e7c6478653c87ef5681d32f3fba5d9ac4846ef 100644 (file)
@@ -550,14 +550,13 @@ static int sym53c8xx_queue_command(struct scsi_cmnd *cmd,
  */
 static irqreturn_t sym53c8xx_intr(int irq, void *dev_id)
 {
-       unsigned long flags;
-       struct sym_hcb *np = (struct sym_hcb *)dev_id;
+       struct sym_hcb *np = dev_id;
 
        if (DEBUG_FLAGS & DEBUG_TINY) printf_debug ("[");
 
-       spin_lock_irqsave(np->s.host->host_lock, flags);
+       spin_lock(np->s.host->host_lock);
        sym_interrupt(np);
-       spin_unlock_irqrestore(np->s.host->host_lock, flags);
+       spin_unlock(np->s.host->host_lock);
 
        if (DEBUG_FLAGS & DEBUG_TINY) printf_debug ("]\n");