]> www.pilppa.org Git - linux-2.6-omap-h63xx.git/commitdiff
[SCSI] sas_ata: Don't copy aic94xx's sactive to ata_port
authorDarrick J. Wong <djwong@us.ibm.com>
Tue, 30 Jan 2007 09:18:44 +0000 (01:18 -0800)
committerJames Bottomley <jejb@mulgrave.localdomain>
Wed, 18 Jul 2007 16:15:20 +0000 (11:15 -0500)
Since the aic94xx sequencer assigns its own NCQ tags to ATA commands, it
no longer makes any sense to copy the sactive field in the STP response
to ata_port->sactive, as that will confuse libata.  Also, libata seems
to be capable of managing sactive on its own.

The attached patch gets rid of one of the causes of the BUG messages in
ata_qc_new, and seems to work without problems on an IBM x206m.

Signed-off-by: Darrick J. Wong <djwong@us.ibm.com>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
drivers/scsi/libsas/sas_ata.c

index c8af884abe188aa5837849b94b2425f4a103f9f3..16c3e5a581ae7014f5c2e14e19ca2453619c25dc 100644 (file)
@@ -106,7 +106,6 @@ static void sas_ata_task_done(struct sas_task *task)
                dev->sata_dev.sstatus = resp->sstatus;
                dev->sata_dev.serror = resp->serror;
                dev->sata_dev.scontrol = resp->scontrol;
-               dev->sata_dev.ap->sactive = resp->sactive;
        } else if (stat->stat != SAM_STAT_GOOD) {
                ac = sas_to_ata_err(stat);
                if (ac) {