]> www.pilppa.org Git - linux-2.6-omap-h63xx.git/commitdiff
[IPV4]: Remove likely in ip_rcv_finish()
authorHua Zhong <hzhong@gmail.com>
Sun, 7 May 2006 01:11:39 +0000 (18:11 -0700)
committerDavid S. Miller <davem@davemloft.net>
Sun, 7 May 2006 01:11:39 +0000 (18:11 -0700)
This is another result from my likely profiling tool
(dwalker@mvista.com just sent the patch of the profiling tool to
linux-kernel mailing list, which is similar to what I use).

On my system (not very busy, normal development machine within a
VMWare workstation), I see a 6/5 miss/hit ratio for this "likely".

Signed-off-by: Hua Zhong <hzhong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/ip_input.c

index 18d7fad474d72510e18177837912e5ff26ea4acb..c9026dbf4c9342cca958490aed1dec45aa36abfa 100644 (file)
@@ -337,7 +337,7 @@ static inline int ip_rcv_finish(struct sk_buff *skb)
         *      Initialise the virtual path cache for the packet. It describes
         *      how the packet travels inside Linux networking.
         */ 
-       if (likely(skb->dst == NULL)) {
+       if (skb->dst == NULL) {
                int err = ip_route_input(skb, iph->daddr, iph->saddr, iph->tos,
                                         skb->dev);
                if (unlikely(err)) {