]> www.pilppa.org Git - linux-2.6-omap-h63xx.git/commit
cpu hotplug: mce: fix cpu hotplug error handling
authorAkinobu Mita <akinobu.mita@gmail.com>
Thu, 18 Oct 2007 10:05:15 +0000 (03:05 -0700)
committerLinus Torvalds <torvalds@woody.linux-foundation.org>
Thu, 18 Oct 2007 21:37:21 +0000 (14:37 -0700)
commitd435d862baca3e25e5eec236762a43251b1e7ffc
tree496fd1ee75f9f6a0da9349275e5dc40c7690cdcb
parent881a841f4ae268207c29721532406ad061e41857
cpu hotplug: mce: fix cpu hotplug error handling

- Clear kobject in percpu device_mce before calling sysdev_register() with

  Because mce_create_device() may fail and it leaves kobject filled with
  junk. It will be the problem when mce_create_device() will be called
  next time.

- Fix error handling in mce_create_device()

  Error handling should not do sysdev_remove_file() with not yet added
  attributes.

- Don't register hotcpu notifier when mce_create_device() returns error

- Do mce_create_device() in CPU_UP_PREPARE instead of CPU_ONLINE

Cc: Andi Kleen <andi@firstfloor.org>
Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Cc: Gautham R Shenoy <ego@in.ibm.com>
Cc: Oleg Nesterov <oleg@tv-sign.ru>
Cc: Andi Kleen <ak@suse.de>
Cc: Jan Beulich <jbeulich@novell.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
arch/x86/kernel/mce_64.c