]> www.pilppa.org Git - linux-2.6-omap-h63xx.git/commit
eCryptfs: remove unnecessary page decrypt call
authorMichael Halcrow <mhalcrow@us.ibm.com>
Fri, 6 Jun 2008 05:46:02 +0000 (22:46 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Fri, 6 Jun 2008 18:29:09 +0000 (11:29 -0700)
commitd3e49afbb66109613c3474f2273f5830ac2dcb09
treed4c3330878741db68f1cac649e070b464ea59204
parentc45dcabd2626c56f8c1235df9db065f584f3ac82
eCryptfs: remove unnecessary page decrypt call

The page decrypt calls in ecryptfs_write() are both pointless and buggy.
Pointless because ecryptfs_get_locked_page() has already brought the page
up to date, and buggy because prior mmap writes will just be blown away by
the decrypt call.

This patch also removes the declaration of a now-nonexistent function
ecryptfs_write_zeros().

Thanks to Eric Sandeen and David Kleikamp for helping to track this
down.

Eric said:

   fsx w/ mmap dies quickly ( < 100 ops) without this, and survives
   nicely (to millions of ops+) with it in place.

Signed-off-by: Michael Halcrow <mhalcrow@us.ibm.com>
Cc: Eric Sandeen <sandeen@redhat.com>
Cc: Dave Kleikamp <shaggy@austin.ibm.com>
Cc: <stable@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/ecryptfs/ecryptfs_kernel.h
fs/ecryptfs/read_write.c