]> www.pilppa.org Git - linux-2.6-omap-h63xx.git/commit
8139too: some style cleanups
authorMárton Németh <nm127@freemail.hu>
Sun, 15 Jun 2008 07:52:30 +0000 (09:52 +0200)
committerJeff Garzik <jgarzik@redhat.com>
Sat, 28 Jun 2008 14:23:35 +0000 (10:23 -0400)
commita9879c4fca9d93ccfb48d642421f3f6211eceec4
treeef5190cdb14596f381cb0c7535463562cfb48f61
parent818727badc14ce57dc099a075b05505d50b7956e
8139too: some style cleanups

Clean up the following errors and warnings reported by checkpatch.pl:
 + ERROR: Macros with complex values should be enclosed in parenthesis
 + WARNING: __func__ should be used instead of gcc specific __FUNCTION__
 + WARNING: plain inline is preferred over __inline__
 + WARNING: Use #include <linux/io.h> instead of <asm/io.h>
 + WARNING: Use #include <linux/uaccess.h> instead of <asm/uaccess.h>

The changes were verified with by comparing the "objdump -d 8139too.ko"
output which is exactly the same for the old and new version in case of
config CONFIG_8139TOO=m, CONFIG_8139TOO_PIO=n, CONFIG_8139TOO_TUNE_TWISTER=n,
CONFIG_8139TOO_8129=n, CONFIG_8139_OLD_RX_RESET=n.
Software versions used: gcc 4.2.3, objdump 2.18.0.20080103, on elf32-i386.

Signed-off-by: Márton Németh <nm127@freemail.hu>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
drivers/net/8139too.c