]> www.pilppa.org Git - linux-2.6-omap-h63xx.git/commit
[CIFS] fix oops on second mount to same server when null auth is used
authorJeff Layton <jlayton@redhat.com>
Fri, 9 Nov 2007 23:25:04 +0000 (23:25 +0000)
committerSteve French <sfrench@us.ibm.com>
Fri, 9 Nov 2007 23:25:04 +0000 (23:25 +0000)
commit9b8f5f573770f33b28c45255ac82e6457278c782
tree1a15c5861fec57963a46356f2d276585e477c81c
parenta6f8de3d9b124c95893054fd2a78bc7be5bb9000
[CIFS] fix oops on second mount to same server when null auth is used

When a share is mounted using no username, cifs_mount sets
volume_info.username as a NULL pointer, and the sesInfo userName as an
empty string. The volume_info.username is passed to a couple of other
functions to see if there is an existing unc or tcp connection that can
be used. These functions assume that the username will be a valid
string that can be passed to strncmp. If the pointer is NULL, then the
kernel will oops if there's an existing session to which the string
can be compared.

This patch changes cifs_mount to set volume_info.username to an empty
string in this situation, which prevents the oops and should make it
so that the comparison to other null auth sessions match.

Signed-off-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Steve French <sfrench@us.ibm.com>
fs/cifs/CHANGES
fs/cifs/connect.c