]> www.pilppa.org Git - linux-2.6-omap-h63xx.git/commit
pkt_sched: Add queue stopped test back to qdisc_run().
authorDavid S. Miller <davem@davemloft.net>
Wed, 13 Aug 2008 09:13:34 +0000 (02:13 -0700)
committerDavid S. Miller <davem@davemloft.net>
Wed, 13 Aug 2008 09:13:34 +0000 (02:13 -0700)
commit83f36f3f35f4f83fa346bfff58a5deabc78370e5
tree6e3c252967f33b76a60585c2702878c153649fbc
parent5e0115e500fe9dd2ca11e6f92db9123204f1327a
pkt_sched: Add queue stopped test back to qdisc_run().

Based upon a bug report by Andrew Gallatin on netdev
with subject "CPU utilization increased in 2.6.27rc"

In commit 37437bb2e1ae8af470dfcd5b4ff454110894ccaf
("pkt_sched: Schedule qdiscs instead of netdev_queue.")
the test of the queue being stopped was erroneously
removed from qdisc_run().

When the TX queue of the device fills up, this omission
causes lots of extraneous useless work to be queued up
to softirq context, where we'll just return immediately
because the device is still stuffed up.

Signed-off-by: David S. Miller <davem@davemloft.net>
include/net/pkt_sched.h