]> www.pilppa.org Git - linux-2.6-omap-h63xx.git/commit
[POWERPC] Fix bug adding properties with flatdevtree.c's ft_set_prop()
authorDavid Gibson <david@gibson.dropbear.id.au>
Mon, 14 May 2007 03:13:57 +0000 (13:13 +1000)
committerPaul Mackerras <paulus@samba.org>
Thu, 17 May 2007 11:11:13 +0000 (21:11 +1000)
commit7c40542ffaa20e361f5f37d112aba41a725fc759
treebc2908cedab914c0c78584cac66ee618b4ae35f2
parente3d67b663b5ededac1b2c552b4f0b4fbe94d7ac3
[POWERPC] Fix bug adding properties with flatdevtree.c's ft_set_prop()

ft_set_prop() from flatdevtree.c in the zImage wrapper will either
replace an existing property in the flat device tree, or add a new
property definiion if the given property isn't present.

However, when adding properties, it adds the property definition
immediately before the node's END_NODE tag, potentially after any
subnode definitions for the node.  This confuses the kernel flat tree
parser in prom.c which assumes that all property definitions for a
node come before all subnode definitions.

This patch corrects ft_set_prop() so that it adds new properties
before the first subnode, instead of before the END_NODE tag.

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Acked-by: Scott Wood <scottwood@freescale.com>
Acked-by: Mark A. Greer <mgreer@mvista.com>
Signed-off-by: Paul Mackerras <paulus@samba.org>
arch/powerpc/boot/flatdevtree.c