From: Andrzej Zaborowski Date: Fri, 15 Feb 2008 23:15:07 +0000 (-0800) Subject: OMAP: LCD: parameter order typo X-Git-Tag: v2.6.25-omap1~195 X-Git-Url: http://www.pilppa.org/gitweb/gitweb.cgi?a=commitdiff_plain;h=a4aa5b2e137b0e140115bce812b2fa701fcec5b9;p=linux-2.6-omap-h63xx.git OMAP: LCD: parameter order typo Value and register offset got swapped in a dispc write. I noticed no malfunction connected with this, only a strange write to *_REVISION (offset zero). Signed-off-by: Andrzej Zaborowski Signed-off-by: Tony Lindgren --- diff --git a/drivers/video/omap/dispc.c b/drivers/video/omap/dispc.c index 5c643f09fba..4c055a24554 100644 --- a/drivers/video/omap/dispc.c +++ b/drivers/video/omap/dispc.c @@ -1405,7 +1405,7 @@ static int omap_dispc_init(struct omapfb_device *fbdev, int ext_mode, dispc_write_reg(DISPC_CONFIG, l); l = dispc_read_reg(DISPC_IRQSTATUS); - dispc_write_reg(l, DISPC_IRQSTATUS); + dispc_write_reg(DISPC_IRQSTATUS, l); /* Enable those that we handle always */ omap_dispc_enable_irqs(DISPC_IRQ_FRAMEMASK); diff --git a/drivers/video/omap/lcd_mipid.c b/drivers/video/omap/lcd_mipid.c index ef071a600b0..3af8b2fd971 100644 --- a/drivers/video/omap/lcd_mipid.c +++ b/drivers/video/omap/lcd_mipid.c @@ -453,7 +453,7 @@ static int panel_enabled(struct mipid_device *md) disp_status = __be32_to_cpu(disp_status); enabled = (disp_status & (1 << 17)) && (disp_status & (1 << 10)); dev_dbg(&md->spi->dev, - "LCD panel %s enabled by bootloader (status 0x%04x)\n", + "LCD panel %senabled by bootloader (status 0x%04x)\n", enabled ? "" : "not ", disp_status); return enabled; }