From: Uwe Kleine-König Date: Fri, 27 Mar 2009 23:27:10 +0000 (+0100) Subject: ALSA: move snd_powermac's probe function to .devinit.text X-Git-Url: http://www.pilppa.org/gitweb/gitweb.cgi?a=commitdiff_plain;h=7d2ac1036b7ff57f73ab64fd897867ddc07bcffe;p=linux-2.6-omap-h63xx.git ALSA: move snd_powermac's probe function to .devinit.text A pointer to snd_pmac_probe is passed to the core via platform_driver_register and so the function must not disappear when the .init sections are discarded. Otherwise (when having HOTPLUG=y) unbinding and binding a device to the driver via sysfs will result in an oops as does a device being registered late. An alternative to this patch is using platform_driver_probe instead of platform_driver_register plus removing the pointer to the probe function from the struct platform_driver. Signed-off-by: Uwe Kleine-König Cc: Jaroslav Kysela Cc: Johannes Berg Cc: Rene Herman Cc: Andrew Morton Signed-off-by: Takashi Iwai --- diff --git a/sound/ppc/powermac.c b/sound/ppc/powermac.c index 5a929069dce..a2b69b8cff4 100644 --- a/sound/ppc/powermac.c +++ b/sound/ppc/powermac.c @@ -51,7 +51,7 @@ static struct platform_device *device; /* */ -static int __init snd_pmac_probe(struct platform_device *devptr) +static int __devinit snd_pmac_probe(struct platform_device *devptr) { struct snd_card *card; struct snd_pmac *chip;