From: Arjan van de Ven Date: Sun, 21 Sep 2008 02:09:00 +0000 (-0700) Subject: debug: use dev_WARN() rather than WARN_ON() in device_pm_add() X-Git-Tag: v2.6.28-rc1~284^2~14 X-Git-Url: http://www.pilppa.org/gitweb/gitweb.cgi?a=commitdiff_plain;h=728f08934b087b96aacb00467f5551e0a5593fca;hp=e61396627f91abb855ddd8925be9172fb5871944;p=linux-2.6-omap-h63xx.git debug: use dev_WARN() rather than WARN_ON() in device_pm_add() device_pm_add() has a WARN_ON that is showing relatively high on kerneloops.org, but unfortunately the WARN_ON is less than useful in that it doesn't print any information about what device is causing the issue. This patch fixes this by turning the WARN_ON() into the newly introduces dev_WARN() which will print information about the device in question. Signed-off-by: Arjan van de Ven Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/base/power/main.c b/drivers/base/power/main.c index 273a944d404..b0eb6afdd86 100644 --- a/drivers/base/power/main.c +++ b/drivers/base/power/main.c @@ -83,7 +83,7 @@ void device_pm_add(struct device *dev) * transition is in progress in order to avoid leaving them * unhandled down the road */ - WARN_ON(true); + dev_WARN(dev, "Parentless device registered during a PM transaction\n"); } list_add_tail(&dev->power.entry, &dpm_list);