From: Florian Westphal Date: Sun, 24 Jun 2007 05:59:40 +0000 (-0700) Subject: [TIPC]: Fix infinite loop in netlink handler X-Git-Tag: v2.6.22-rc6~2^2~5 X-Git-Url: http://www.pilppa.org/gitweb/gitweb.cgi?a=commitdiff_plain;h=64beb8f3eb3c724add64ca3272915528e10213c1;p=linux-2.6-omap-h63xx.git [TIPC]: Fix infinite loop in netlink handler The tipc netlink config handler uses the nlmsg_pid from the request header as destination for its reply. If the application initialized nlmsg_pid to 0, the reply is looped back to the kernel, causing hangup. Fix: use nlmsg_pid of the skb that triggered the request. Signed-off-by: Florian Westphal Signed-off-by: David S. Miller --- diff --git a/net/tipc/netlink.c b/net/tipc/netlink.c index 4cdafa2d1d4..6a7f7b4c259 100644 --- a/net/tipc/netlink.c +++ b/net/tipc/netlink.c @@ -60,7 +60,7 @@ static int handle_cmd(struct sk_buff *skb, struct genl_info *info) rep_nlh = nlmsg_hdr(rep_buf); memcpy(rep_nlh, req_nlh, hdr_space); rep_nlh->nlmsg_len = rep_buf->len; - genlmsg_unicast(rep_buf, req_nlh->nlmsg_pid); + genlmsg_unicast(rep_buf, NETLINK_CB(skb).pid); } return 0;