From: Mark Brown Date: Mon, 16 Mar 2009 19:36:33 +0000 (+0000) Subject: regulator: Don't increment use_count for boot_on regulators X-Git-Url: http://www.pilppa.org/gitweb/gitweb.cgi?a=commitdiff_plain;h=50f075963f127d713ff0c30359baefc0f89d9ae2;p=linux-2.6-omap-h63xx.git regulator: Don't increment use_count for boot_on regulators Don't set use_count for regulators that are enabled at boot since this stops the supply being disabled by well-behaved consumers which do balanced enables and disabled. Any consumers which don't do disables which are not matched by enables are unable to share regulators - shared regulators are the common case so the API should facilitate them. Consumers that want to disable regulators that are enabled when they start have two options: - Do a regulator_enable() prior to the disable to bring the use count in sync with the hardware state; this will ensure that if the regulator was enabled by another driver then this consumer will play nicely with it. - Use regulator_force_disable(); this explicitly bypasses any checks done by the core and documents the inability of the driver to share the supply. Signed-off-by: Mark Brown Signed-off-by: Liam Girdwood --- diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index 944887578d6..8588a2490e0 100644 --- a/drivers/regulator/core.c +++ b/drivers/regulator/core.c @@ -814,7 +814,6 @@ static int set_machine_constraints(struct regulator_dev *rdev, rdev->constraints = NULL; goto out; } - rdev->use_count = 1; } print_constraints(rdev);