From: Dave Jones <davej@redhat.com>
Date: Mon, 27 Mar 2006 09:14:57 +0000 (-0800)
Subject: [PATCH] Remove redundant check from autofs4_put_super
X-Git-Tag: v2.6.17-rc1~442
X-Git-Url: http://www.pilppa.org/gitweb/gitweb.cgi?a=commitdiff_plain;h=3370c74b2e147169d5bba6665e03d3281f5795ed;p=linux-2.6-omap-h63xx.git

[PATCH] Remove redundant check from autofs4_put_super

We have to have a valid sbi here, or we'd have oopsed already.  (There's a
dereference of sbi->catatonic a few lines above)

Coverity #740

Signed-off-by: Dave Jones <davej@redhat.com>
Cc: Ian Kent <raven@themaw.net>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
---

diff --git a/fs/autofs4/inode.c b/fs/autofs4/inode.c
index 94388890549..4eddee4e76f 100644
--- a/fs/autofs4/inode.c
+++ b/fs/autofs4/inode.c
@@ -157,8 +157,7 @@ static void autofs4_put_super(struct super_block *sb)
 		autofs4_catatonic_mode(sbi); /* Free wait queues, close pipe */
 
 	/* Clean up and release dangling references */
-	if (sbi)
-		autofs4_force_release(sbi);
+	autofs4_force_release(sbi);
 
 	kfree(sbi);