From: Stephen Hemminger <shemminger@osdl.org>
Date: Tue, 7 Mar 2006 19:06:35 +0000 (-0800)
Subject: sky2: not random enough
X-Git-Tag: v2.6.16-rc6~6^2~2
X-Git-Url: http://www.pilppa.org/gitweb/gitweb.cgi?a=commitdiff_plain;h=28a31860191c0d5710d42f85510daac0a3c26a01;p=linux-2.6-omap-h63xx.git

sky2: not random enough

Don't use sky2 to seed random pool beacause the network packet arrival time
will not be truly random due to NAPI and interrupt mitigation.

Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
---

diff --git a/drivers/net/sky2.c b/drivers/net/sky2.c
index 72c1630977d..dc4feaf79be 100644
--- a/drivers/net/sky2.c
+++ b/drivers/net/sky2.c
@@ -3243,8 +3243,7 @@ static int __devinit sky2_probe(struct pci_dev *pdev,
 		}
 	}
 
-	err = request_irq(pdev->irq, sky2_intr, SA_SHIRQ | SA_SAMPLE_RANDOM,
-			  DRV_NAME, hw);
+	err = request_irq(pdev->irq, sky2_intr, SA_SHIRQ, DRV_NAME, hw);
 	if (err) {
 		printk(KERN_ERR PFX "%s: cannot assign irq %d\n",
 		       pci_name(pdev), pdev->irq);