]> www.pilppa.org Git - linux-2.6-omap-h63xx.git/commitdiff
tracing: fix printk format specifier
authorSteven Rostedt <srostedt@redhat.com>
Tue, 10 Mar 2009 14:14:35 +0000 (10:14 -0400)
committerSteven Rostedt <srostedt@redhat.com>
Tue, 10 Mar 2009 14:14:35 +0000 (10:14 -0400)
Impact: clean up

The offsetof and sizeof are of type size_t, and instead of typecasting
them to unsigned int for printk formatting, one could just use %zu.

Reported-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Steven Rostedt <srostedt@redhat.com>
kernel/trace/trace_events.c

index 1880a643809785a173fa5709169f26c3c268851d..a0b41cc26f267223587aaf434222f159193979d8 100644 (file)
@@ -338,8 +338,7 @@ event_enable_write(struct file *filp, const char __user *ubuf, size_t cnt,
 
 #undef FIELD
 #define FIELD(type, name)                                              \
-       #type, #name, (unsigned int)offsetof(typeof(field), name),      \
-               (unsigned int)sizeof(field.name)
+       #type, #name, offsetof(typeof(field), name), sizeof(field.name)
 
 static int trace_write_header(struct trace_seq *s)
 {
@@ -347,11 +346,11 @@ static int trace_write_header(struct trace_seq *s)
 
        /* struct trace_entry */
        return trace_seq_printf(s,
-                               "\tfield:%s %s;\toffset:%u;\tsize:%u;\n"
-                               "\tfield:%s %s;\toffset:%u;\tsize:%u;\n"
-                               "\tfield:%s %s;\toffset:%u;\tsize:%u;\n"
-                               "\tfield:%s %s;\toffset:%u;\tsize:%u;\n"
-                               "\tfield:%s %s;\toffset:%u;\tsize:%u;\n"
+                               "\tfield:%s %s;\toffset:%zu;\tsize:%zu;\n"
+                               "\tfield:%s %s;\toffset:%zu;\tsize:%zu;\n"
+                               "\tfield:%s %s;\toffset:%zu;\tsize:%zu;\n"
+                               "\tfield:%s %s;\toffset:%zu;\tsize:%zu;\n"
+                               "\tfield:%s %s;\toffset:%zu;\tsize:%zu;\n"
                                "\n",
                                FIELD(unsigned char, type),
                                FIELD(unsigned char, flags),