]> www.pilppa.org Git - linux-2.6-omap-h63xx.git/commitdiff
dsp_fbexport: use kzalloc
authorArnaud Patard <Rtp>
Thu, 9 Nov 2006 23:52:34 +0000 (01:52 +0200)
committerTony Lindgren <tony@atomide.com>
Thu, 9 Nov 2006 23:52:34 +0000 (01:52 +0200)
The dsp_export function calls omapfb_register_client() right after
allocating the memory with kmalloc.
A commit added to omapfb_register_client() a check on the value of
plane_idx in the notified block structure. As we're only using kmalloc,
you may end-up comparing garbage/random values (It even leads to a oops
on my n770).

Using kzalloc() fixes the issue.

Signed-off-by: Arnaud Patard <arnaud.patard@rtp-net.org>
Signed-off-by: Tony Lindgren <tony@atomide.com>
arch/arm/plat-omap/dsp/dsp_mem.c

index ac45fafaa5fe95ffd6cbea6e1bb9aadda70653f0..b53cdc7e1babcc0a790460c757f81ea04103c7e7 100644 (file)
@@ -1495,7 +1495,7 @@ static int dsp_fbexport(dsp_long_t *dspadr)
 #endif
 
 #ifdef CONFIG_FB_OMAP_LCDC_EXTERNAL
-       omapfb_nb = kmalloc(sizeof(struct omapfb_notifier_block), GFP_KERNEL);
+       omapfb_nb = kzalloc(sizeof(struct omapfb_notifier_block), GFP_KERNEL);
        if (omapfb_nb == NULL) {
                printk(KERN_ERR
                       "omapdsp: failed to allocate memory for omapfb_nb!\n");