]> www.pilppa.org Git - linux-2.6-omap-h63xx.git/commitdiff
[POWERPC] arch/ppc: Remove an unnecessary pci_dev_put
authorJulia Lawall <julia@diku.dk>
Thu, 13 Dec 2007 23:56:07 +0000 (15:56 -0800)
committerPaul Mackerras <paulus@samba.org>
Thu, 20 Dec 2007 06:13:50 +0000 (17:13 +1100)
Remove an unnecessary pci_dev_put.  pci_dev_put is called implicitly
by the subsequent call to pci_get_device.

The problem was detected using the following semantic patch, and
corrected by hand.

@@
expression dev;
expression E;
@@

- pci_dev_put(dev)
   ... when != dev = E
- pci_get_device(...,dev)

Signed-off-by: Julia Lawall <julia@diku.dk>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Paul Mackerras <paulus@samba.org>
arch/ppc/platforms/prep_pci.c

index 1df3150f016eadb812c079f5724352ccc63c8ad3..8ed433e2a5c77a6d2f9c036b15960cb2a600ac0e 100644 (file)
@@ -1099,7 +1099,6 @@ prep_pib_init(void)
                                pci_write_config_byte(dev, 0x43, reg);
                        }
                }
-               pci_dev_put(dev);
        }
 
        if ((dev = pci_get_device(PCI_VENDOR_ID_WINBOND,