]> www.pilppa.org Git - linux-2.6-omap-h63xx.git/commitdiff
drivers/infiniband/hw/mthca/mthca_qp: kill uninit'd var warning
authorJeff Garzik <jeff@garzik.org>
Tue, 17 Jul 2007 06:03:49 +0000 (02:03 -0400)
committerJeff Garzik <jeff@garzik.org>
Tue, 17 Jul 2007 20:18:00 +0000 (16:18 -0400)
drivers/infiniband/hw/mthca/mthca_qp.c: In function
  ‘mthca_tavor_post_send’:
drivers/infiniband/hw/mthca/mthca_qp.c:1594: warning: ‘f0’ may be used
  uninitialized in this function
drivers/infiniband/hw/mthca/mthca_qp.c: In function
  ‘mthca_arbel_post_send’:
drivers/infiniband/hw/mthca/mthca_qp.c:1949: warning: ‘f0’ may be used
  uninitialized in this function

Initializing 'f0' is not strictly necessary in either case, AFAICS.

I was considering use of uninitialized_var(), but looking at the
complex flow of control in each function, I feel it is wiser and
safer to simply zero the var and be certain of ourselves.

Signed-off-by: Jeff Garzik <jeff@garzik.org>
drivers/infiniband/hw/mthca/mthca_qp.c

index eef415b12b2ebda3d60043bf4b7f9cf8fee72563..11f1d99db40b5896698d98bf81a90a48e3c54879 100644 (file)
@@ -1591,7 +1591,7 @@ int mthca_tavor_post_send(struct ib_qp *ibqp, struct ib_send_wr *wr,
        int i;
        int size;
        int size0 = 0;
-       u32 f0;
+       u32 f0 = 0;
        int ind;
        u8 op0 = 0;
 
@@ -1946,7 +1946,7 @@ int mthca_arbel_post_send(struct ib_qp *ibqp, struct ib_send_wr *wr,
        int i;
        int size;
        int size0 = 0;
-       u32 f0;
+       u32 f0 = 0;
        int ind;
        u8 op0 = 0;