]> www.pilppa.org Git - linux-2.6-omap-h63xx.git/commitdiff
I2C: i2c subsystem should print error messages
authorFelipe Balbi <felipe.balbi@nokia.com>
Thu, 17 Apr 2008 12:29:01 +0000 (15:29 +0300)
committerTony Lindgren <tony@atomide.com>
Mon, 21 Apr 2008 18:46:51 +0000 (11:46 -0700)
We don't have to print any error message if i2c_add_driver
fails since i2c subsystem already does it.

Signed-off-by: Felipe Balbi <felipe.balbi@nokia.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
drivers/i2c/chips/isp1301_omap.c
drivers/i2c/chips/menelaus.c

index 6ebff9cc337ad4a7346a0e304efd6f1848a4a10d..09f96627bbc7fba00b357d6caf3eed129c6b07a3 100644 (file)
@@ -1606,15 +1606,7 @@ static struct i2c_driver isp1301_driver = {
 
 static int __init isp_init(void)
 {
-       int     status = -ENODEV;
-
-       printk(KERN_INFO "%s: version %s\n", DRIVER_NAME, DRIVER_VERSION);
-
-       status = i2c_add_driver(&isp1301_driver);
-       if (status)
-               printk(KERN_ERR "%s failed to probe\n", DRIVER_NAME);
-
-       return status;
+       return i2c_add_driver(&isp1301_driver);
 }
 module_init(isp_init);
 
index 1d7482ae9b102f5380e7e8d6d0a2f05576fc0e94..d4d1ccc954866d693bd8bba651701a1c1fb614bb 100644 (file)
@@ -1281,15 +1281,7 @@ static struct i2c_driver menelaus_i2c_driver = {
 
 static int __init menelaus_init(void)
 {
-       int res;
-
-       res = i2c_add_driver(&menelaus_i2c_driver);
-       if (res < 0) {
-               dev_err(&the_menelaus->client->dev, "driver registration failed\n");
-               return res;
-       }
-
-       return 0;
+       return i2c_add_driver(&menelaus_i2c_driver);
 }
 
 static void __exit menelaus_exit(void)