]> www.pilppa.org Git - linux-2.6-omap-h63xx.git/commitdiff
x86: Mark OPTIMIZE_INLINING broken
authorLinus Torvalds <torvalds@linux-foundation.org>
Thu, 1 May 2008 02:50:03 +0000 (19:50 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Thu, 1 May 2008 03:07:22 +0000 (20:07 -0700)
So Ingo finally did figure out why UML broke with this option: UML
passes gcc the -fno-unit-at-a-time flag, and apparently that wreaks
havoc with gcc's inlining.

We could turn off -fno-unit-at-a-time for UML for gcc4+ (which is what
x86 does), but there's bad blood about this whole option, and it does
show that the thing is just fragile as heck.

So let tempers cool, and disable the thing, and we can revisit the
decision later.

Cc: Adrian Bunk <bunk@kernel.org>
Cc: David Miller <davem@davemloft.net>
Acked-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
arch/x86/Kconfig.debug

index 5fc8d0b3191da4d1b79c32a5ed127bb994b27b0c..ac1e31ba4795cb0f067a280826da257432f93f33 100644 (file)
@@ -257,6 +257,7 @@ config CPA_DEBUG
 
 config OPTIMIZE_INLINING
        bool "Allow gcc to uninline functions marked 'inline'"
+       depends on BROKEN
        help
          This option determines if the kernel forces gcc to inline the functions
          developers have marked 'inline'. Doing so takes away freedom from gcc to