]> www.pilppa.org Git - linux-2.6-omap-h63xx.git/commitdiff
WDEV: ath5k, fix lock imbalance
authorJiri Slaby <jirislaby@gmail.com>
Fri, 15 Feb 2008 20:58:51 +0000 (21:58 +0100)
committerJohn W. Linville <linville@tuxdriver.com>
Thu, 21 Feb 2008 01:11:48 +0000 (20:11 -0500)
Omitted lock causes sparse warning
drivers/net/wireless/ath5k/base.c:1682:1: warning: context imbalance in 'ath5k_tasklet_rx' - different lock contexts for basic block

Add the lock to the guilty fail path.

Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Acked-by: Nick Kossifidis <mickflemm@gmail.com>
Cc: Luis R. Rodriguez <mcgrof@gmail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/ath5k/base.c

index dfdaec020739c5ec6bfae806a18b41a7a2c61aa2..062d004076a22eb2ece3e7629c0e7da772302b61 100644 (file)
@@ -1715,6 +1715,7 @@ ath5k_tasklet_rx(unsigned long data)
                        break;
                else if (unlikely(ret)) {
                        ATH5K_ERR(sc, "error in processing rx descriptor\n");
+                       spin_unlock(&sc->rxbuflock);
                        return;
                }