]> www.pilppa.org Git - linux-2.6-omap-h63xx.git/commitdiff
x86-32: tighten the bound on additional memory to map
authorH. Peter Anvin <hpa@linux.intel.com>
Tue, 17 Mar 2009 18:38:23 +0000 (11:38 -0700)
committerH. Peter Anvin <hpa@linux.intel.com>
Tue, 17 Mar 2009 18:52:10 +0000 (11:52 -0700)
Impact: Tighten bound to avoid masking errors

The definition of MAPPING_BEYOND_END was excessive; this has a nasty
tendency to mask bugs.  We have learned over time that this kind of
bug hiding can cause some very strange errors.  Therefore, tighten the
bound to only need to map the actual kernel area.

Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
Cc: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
Cc: Yinghai Lu <yinghai@kernel.org>
arch/x86/kernel/head_32.S

index fc884b90b6d25affd9fa2bf72e1007db19332bd9..30683883e0cdcf0bd669cb439206fefaf74301f2 100644 (file)
@@ -60,7 +60,8 @@
 #endif
 
 /* Enough space to fit pagetables for the low memory linear map */
-MAPPING_BEYOND_END = (PAGE_TABLE_SIZE(1 << (32 - PAGE_SHIFT)) * PAGE_SIZE)
+MAPPING_BEYOND_END = \
+       PAGE_TABLE_SIZE(((1<<32) - __PAGE_OFFSET) >> PAGE_SHIFT) << PAGE_SHIFT
 
 /*
  * Worst-case size of the kernel mapping we need to make: