]> www.pilppa.org Git - linux-2.6-omap-h63xx.git/commitdiff
drivers/base: Platform notify needs to occur before drivers attach to the device
authorBrian Walsh <brian@walsh.ws>
Tue, 15 Aug 2006 05:43:19 +0000 (22:43 -0700)
committerGreg Kroah-Hartman <gregkh@suse.de>
Tue, 26 Sep 2006 04:08:39 +0000 (21:08 -0700)
The platform_notify call for Arm and PPC architectures needs to be called
before the driver attaches to the device.  The problem only presents itself
when hotplugging certain devices while the driver is already loaded.

Signed-off-by: Brian Walsh <brian@walsh.ws>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/base/core.c

index bc9f35c816918b5ed9c4accc0af20c89186f27c4..b224bb43ff638f812694efe1e4c8eaa5bbd47967 100644 (file)
@@ -424,6 +424,10 @@ int device_add(struct device *dev)
        if ((error = kobject_add(&dev->kobj)))
                goto Error;
 
+       /* notify platform of device entry */
+       if (platform_notify)
+               platform_notify(dev);
+
        dev->uevent_attr.attr.name = "uevent";
        dev->uevent_attr.attr.mode = S_IWUSR;
        if (dev->driver)
@@ -488,10 +492,6 @@ int device_add(struct device *dev)
                                class_intf->add_dev(dev, class_intf);
                up(&dev->class->sem);
        }
-
-       /* notify platform of device entry */
-       if (platform_notify)
-               platform_notify(dev);
  Done:
        kfree(class_name);
        put_device(dev);