]> www.pilppa.org Git - linux-2.6-omap-h63xx.git/commitdiff
[PATCH] powerpc: Fix bug in bug fix for bug in lmb_alloc()
authorMichael Ellerman <michael@ellerman.id.au>
Thu, 16 Mar 2006 03:47:20 +0000 (14:47 +1100)
committerPaul Mackerras <paulus@samba.org>
Fri, 17 Mar 2006 02:28:24 +0000 (13:28 +1100)
My patch (d7a5b2ffa1352f0310630934a56aecbdfb617b72) to always panic if
lmb_alloc() fails is broken because it checks alloc < 0, but should be
checking alloc == 0.

Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
Signed-off-by: Paul Mackerras <paulus@samba.org>
arch/powerpc/mm/lmb.c

index 874cd103ce6ea2e4303d3007620a3169010de994..417d58518558bd0ab31975df7e7d864d6aea3a05 100644 (file)
@@ -232,7 +232,7 @@ unsigned long __init lmb_alloc_base(unsigned long size, unsigned long align,
 
        alloc = __lmb_alloc_base(size, align, max_addr);
 
-       if (alloc < 0)
+       if (alloc == 0)
                panic("ERROR: Failed to allocate 0x%lx bytes below 0x%lx.\n",
                                size, max_addr);