]> www.pilppa.org Git - linux-2.6-omap-h63xx.git/commitdiff
ARM: OMAP: Fix musb_core parameter passing to cppi start
authorDirk Behme <dirk.behme@googlemail.com>
Mon, 8 Oct 2007 18:35:14 +0000 (20:35 +0200)
committerTony Lindgren <tony@atomide.com>
Tue, 9 Oct 2007 22:25:39 +0000 (15:25 -0700)
cppi_controller_start() expects a struct dma_controller as parameter
and not dma_controller private_data. Current implementation crashes
with e.g.

Internal error: Oops: 805 [#1]
Modules linked in:
CPU: 0    Not tainted  (2.6.23-rc4-davinci1 #2)
PC is at cppi_controller_start+0x18/0x140
LR is at musb_probe+0x1f4/0x824

Fix this. Initial proposal for fix by David Brownell. Thanks!

Signed-off-by: Dirk Behme <dirk.behme@gmail.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
drivers/usb/musb/musb_core.c

index 9a73de521a868da4a8a464d965d21c94b8bc8ea2..3093bda542603b861b3ff912498836863b3dd292 100644 (file)
@@ -1980,7 +1980,7 @@ musb_init_controller(struct device *dev, int nIrq, void __iomem *ctrl)
                c = dma_controller_create(musb, musb->mregs);
                musb->dma_controller = c;
                if (c)
-                       (void) c->start(c->private_data);
+                       (void) c->start(c);
        }
 #endif
        /* ideally this would be abstracted in platform setup */