ARM: OMAP: Fix warnings in plat-omap

Fix warnings

arch/arm/plat-omap/dmtimer.c: In function
'omap_dm_timer_modify_idlect_mask':
arch/arm/plat-omap/dmtimer.c:317: warning: no return
statement in function returning non-void

arch/arm/plat-omap/mailbox.c: In function 'omap_mbox_init':
arch/arm/plat-omap/mailbox.c:231: warning: ignoring return
value of 'class_device_create_file', declared with attribute
warn_unused_result

Signed-off-by: Dirk Behme <dirk.behme_at_gmail.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>

diff --git a/arch/arm/plat-omap/dmtimer.c b/arch/arm/plat-omap/dmtimer.c
index 55b10ce23e683f43bf87e15dc10fc84aeea2664d..d68d18e2ddd235f52c835b806748b50ec64a6f87 100644 (file)
--- a/arch/arm/plat-omap/dmtimer.c
+++ b/arch/arm/plat-omap/dmtimer.c
@@ -314,6 +314,8 @@ struct clk *omap_dm_timer_get_fclk(struct omap_dm_timer *timer)
 __u32 omap_dm_timer_modify_idlect_mask(__u32 inputmask)
 {
        BUG();
+
+       return 0;
 }
 
 #endif

diff --git a/arch/arm/plat-omap/mailbox.c b/arch/arm/plat-omap/mailbox.c
index 96e5ad0b76e3f39c0b910938ba9e262fa67a3921..ab72f22fa22788f919c54b427b2e950caf15cb4e 100644 (file)
--- a/arch/arm/plat-omap/mailbox.c
+++ b/arch/arm/plat-omap/mailbox.c
@@ -228,7 +228,12 @@ static int omap_mbox_init(struct omap_mbox *mbox)
        if (unlikely(ret))
                return ret;
 
-       class_device_create_file(&mbox->class_dev, &class_device_attr_mbox);
+       ret = class_device_create_file(&mbox->class_dev, &class_device_attr_mbox);
+       if (unlikely(ret)) {
+               printk(KERN_ERR
+                      "class_device_create_file failed: %d\n", ret);
+               goto fail1;
+       }
 
        ret = request_irq(mbox->irq, mbox_interrupt, SA_INTERRUPT,
                          mbox->name, mbox);