Get rid of some sparse warnings in twl4030 driver.
Signed-off-by: Felipe Balbi <felipe.balbi@nokia.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
-struct task_struct *start_twl4030_irq_thread(int irq)
+static struct task_struct *start_twl4030_irq_thread(int irq)
{
struct task_struct *thread;
{
struct task_struct *thread;
/* pointer to gpio unmask thread struct */
static struct task_struct *gpio_unmask_thread;
/* pointer to gpio unmask thread struct */
static struct task_struct *gpio_unmask_thread;
-static inline int gpio_twl4030_read(u8 address);
-static inline int gpio_twl4030_write(u8 address, u8 data);
-
/*
* Helper functions to read and write the GPIO ISR and IMR registers as
* 32-bit integers. Functions return 0 on success, non-zero otherwise.
/*
* Helper functions to read and write the GPIO ISR and IMR registers as
* 32-bit integers. Functions return 0 on success, non-zero otherwise.
.unmask = twl4030_gpio_module_unmask,
};
.unmask = twl4030_gpio_module_unmask,
};
+/*
+ * To configure TWL4030 GPIO module registers
+ */
+static inline int gpio_twl4030_write(u8 address, u8 data)
+{
+ int ret = 0;
+
+ ret = twl4030_i2c_write_u8(TWL4030_MODULE_GPIO, data, address);
+ return ret;
+}
+
+/*
+ * To read a TWL4030 GPIO module register
+ */
+static inline int gpio_twl4030_read(u8 address)
+{
+ u8 data;
+ int ret = 0;
+
+ ret = twl4030_i2c_read_u8(TWL4030_MODULE_GPIO, &data, address);
+ if (ret >= 0)
+ ret = data;
+ return ret;
+}
+
/*
* twl4030 GPIO request function
*/
/*
* twl4030 GPIO request function
*/
-/*
- * To configure TWL4030 GPIO module registers
- */
-static inline int gpio_twl4030_write(u8 address, u8 data)
-{
- int ret = 0;
-
- ret = twl4030_i2c_write_u8(TWL4030_MODULE_GPIO, data, address);
- return ret;
-}
-
-/*
- * To read a TWL4030 GPIO module register
- */
-static inline int gpio_twl4030_read(u8 address)
-{
- u8 data;
- int ret = 0;
-
- ret = twl4030_i2c_read_u8(TWL4030_MODULE_GPIO, &data, address);
- if (ret >= 0)
- ret = data;
- return ret;
-}
-
/*
* gpio_unmask_thread() runs as a kernel thread. It is awakened by the unmask
* method for the GPIO interrupts. It unmasks all of the GPIO interrupts
/*
* gpio_unmask_thread() runs as a kernel thread. It is awakened by the unmask
* method for the GPIO interrupts. It unmasks all of the GPIO interrupts
#define PWR_P1_SW_EVENTS 0x10
#define PWR_DEVOFF (1<<0)
#define PWR_P1_SW_EVENTS 0x10
#define PWR_DEVOFF (1<<0)
-void twl4030_poweroff(void)
+static void twl4030_poweroff(void)