]> www.pilppa.org Git - linux-2.6-omap-h63xx.git/commitdiff
ARM: OMAP: Pass logical DMA channel number always to callback handlers
authorJarkko Nikula <jarkko.nikula@nokia.com>
Wed, 13 Feb 2008 11:47:29 +0000 (13:47 +0200)
committerTony Lindgren <tony@atomide.com>
Fri, 15 Feb 2008 21:30:44 +0000 (13:30 -0800)
This makes parameter passing to DMA handlers uniform between non-chained
and chained transfers and makes debugging easier. Additional data like
chain_id can be always passed to handlers via callback data if needed.

Signed-off-by: Jarkko Nikula <jarkko.nikula@nokia.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
arch/arm/plat-omap/dma.c

index a46676db81138e5f1e06394179d2ee62fed6c95f..3e94683c966278a967dcaa933c6ae57ad0e3056c 100644 (file)
@@ -1705,14 +1705,8 @@ static int omap2_dma_handle_ch(int ch)
                status = OMAP_DMA_CSR_REG(ch);
        }
 
                status = OMAP_DMA_CSR_REG(ch);
        }
 
-       if (likely(dma_chan[ch].callback != NULL)) {
-               if (dma_chan[ch].chain_id != -1)
-                       dma_chan[ch].callback(dma_chan[ch].chain_id, status,
-                                             dma_chan[ch].data);
-               else
-                       dma_chan[ch].callback(ch, status, dma_chan[ch].data);
-
-       }
+       if (likely(dma_chan[ch].callback != NULL))
+               dma_chan[ch].callback(ch, status, dma_chan[ch].data);
 
        OMAP_DMA_CSR_REG(ch) = status;
 
 
        OMAP_DMA_CSR_REG(ch) = status;