sm501_devdata->irq is unsigned, while platform_get_irq() returns a
signed int.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: Samuel Ortiz <sameo@openedhand.com>
static int sm501_plat_probe(struct platform_device *dev)
{
struct sm501_devdata *sm;
static int sm501_plat_probe(struct platform_device *dev)
{
struct sm501_devdata *sm;
sm = kzalloc(sizeof(struct sm501_devdata), GFP_KERNEL);
if (sm == NULL) {
dev_err(&dev->dev, "no memory for device data\n");
sm = kzalloc(sizeof(struct sm501_devdata), GFP_KERNEL);
if (sm == NULL) {
dev_err(&dev->dev, "no memory for device data\n");
goto err1;
}
sm->dev = &dev->dev;
sm->pdev_id = dev->id;
goto err1;
}
sm->dev = &dev->dev;
sm->pdev_id = dev->id;
- sm->irq = platform_get_irq(dev, 0);
- sm->io_res = platform_get_resource(dev, IORESOURCE_MEM, 1);
- sm->mem_res = platform_get_resource(dev, IORESOURCE_MEM, 0);
sm->platdata = dev->dev.platform_data;
sm->platdata = dev->dev.platform_data;
+ ret = platform_get_irq(dev, 0);
+ if (ret < 0) {
dev_err(&dev->dev, "failed to get irq resource\n");
dev_err(&dev->dev, "failed to get irq resource\n");
+ sm->io_res = platform_get_resource(dev, IORESOURCE_MEM, 1);
+ sm->mem_res = platform_get_resource(dev, IORESOURCE_MEM, 0);
if (sm->io_res == NULL || sm->mem_res == NULL) {
dev_err(&dev->dev, "failed to get IO resource\n");
if (sm->io_res == NULL || sm->mem_res == NULL) {
dev_err(&dev->dev, "failed to get IO resource\n");
if (sm->regs_claim == NULL) {
dev_err(&dev->dev, "cannot claim registers\n");
if (sm->regs_claim == NULL) {
dev_err(&dev->dev, "cannot claim registers\n");
if (sm->regs == NULL) {
dev_err(&dev->dev, "cannot remap registers\n");
if (sm->regs == NULL) {
dev_err(&dev->dev, "cannot remap registers\n");
err_res:
kfree(sm);
err1:
err_res:
kfree(sm);
err1: