ICC complains about a "Pointless comparsion of unsigned interger with zero"
@ line 760 & 808 of asus_acpi.c
parse_arg() mentioned below returns -E but it's copied into unsigned variable...
Signed-off-by: Darren Jenkins <darrenrjenkins@gmail.com>
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Len Brown <len.brown@intel.com>
write_led(const char __user * buffer, unsigned long count,
char *ledname, int ledmask, int invert)
{
write_led(const char __user * buffer, unsigned long count,
char *ledname, int ledmask, int invert)
{
- count = parse_arg(buffer, count, &value);
- if (count > 0)
+ rv = parse_arg(buffer, count, &value);
+ if (rv > 0)
led_out = value ? 1 : 0;
hotk->status =
led_out = value ? 1 : 0;
hotk->status =
printk(KERN_WARNING "Asus ACPI: LED (%s) write failed\n",
ledname);
printk(KERN_WARNING "Asus ACPI: LED (%s) write failed\n",
ledname);
proc_write_ledd(struct file *file, const char __user * buffer,
unsigned long count, void *data)
{
proc_write_ledd(struct file *file, const char __user * buffer,
unsigned long count, void *data)
{
- count = parse_arg(buffer, count, &value);
- if (count > 0) {
+ rv = parse_arg(buffer, count, &value);
+ if (rv > 0) {
if (!write_acpi_int
(hotk->handle, hotk->methods->mt_ledd, value, NULL))
printk(KERN_WARNING
"Asus ACPI: LED display write failed\n");
else
hotk->ledd_status = (u32) value;
if (!write_acpi_int
(hotk->handle, hotk->methods->mt_ledd, value, NULL))
printk(KERN_WARNING
"Asus ACPI: LED display write failed\n");
else
hotk->ledd_status = (u32) value;
printk(KERN_WARNING "Asus ACPI: Error reading user input\n");
printk(KERN_WARNING "Asus ACPI: Error reading user input\n");
proc_write_lcd(struct file *file, const char __user * buffer,
unsigned long count, void *data)
{
proc_write_lcd(struct file *file, const char __user * buffer,
unsigned long count, void *data)
{
- count = parse_arg(buffer, count, &value);
- if (count > 0)
+ rv = parse_arg(buffer, count, &value);
+ if (rv > 0)
}
static int read_brightness(void)
}
static int read_brightness(void)
proc_write_brn(struct file *file, const char __user * buffer,
unsigned long count, void *data)
{
proc_write_brn(struct file *file, const char __user * buffer,
unsigned long count, void *data)
{
- count = parse_arg(buffer, count, &value);
- if (count > 0) {
+ rv = parse_arg(buffer, count, &value);
+ if (rv > 0) {
value = (0 < value) ? ((15 < value) ? 15 : value) : 0;
/* 0 <= value <= 15 */
set_brightness(value);
value = (0 < value) ? ((15 < value) ? 15 : value) : 0;
/* 0 <= value <= 15 */
set_brightness(value);
- } else if (count < 0) {
printk(KERN_WARNING "Asus ACPI: Error reading user input\n");
}
printk(KERN_WARNING "Asus ACPI: Error reading user input\n");
}
}
static void set_display(int value)
}
static void set_display(int value)
proc_write_disp(struct file *file, const char __user * buffer,
unsigned long count, void *data)
{
proc_write_disp(struct file *file, const char __user * buffer,
unsigned long count, void *data)
{
- count = parse_arg(buffer, count, &value);
- if (count > 0)
+ rv = parse_arg(buffer, count, &value);
+ if (rv > 0)
printk(KERN_WARNING "Asus ACPI: Error reading user input\n");
printk(KERN_WARNING "Asus ACPI: Error reading user input\n");
}
typedef int (proc_readfunc) (char *page, char **start, off_t off, int count,
}
typedef int (proc_readfunc) (char *page, char **start, off_t off, int count,