]> www.pilppa.org Git - linux-2.6-omap-h63xx.git/commit
fix historic ioremap() abuse in AGP
authorArjan van dev Ven <arjan@linux.intel.com>
Wed, 6 Feb 2008 04:16:00 +0000 (05:16 +0100)
committerDave Airlie <airlied@linux.ie>
Tue, 19 Feb 2008 04:46:39 +0000 (14:46 +1000)
commitfcea424d31868a78366ad5ee0cb3cc2a4cbe689b
tree9b3a2be661c07d8b094a5489ecafffe4befe5ec0
parent16469a0ea0f6b7562eac98ebb8a7c41ce902d0b1
fix historic ioremap() abuse in AGP

Several AGP drivers right now use ioremap_nocache() on kernel ram in order
to turn a page of regular memory uncached.

There are two problems with this:

    1) This is a total nightmare for the ioremap() implementation to keep
       various mappings of the same page coherent.

    2) It's a total nightmare for the AGP code since it adds a ton of
       complexity in terms of keeping track of 2 different pointers to
       the same thing, in terms of error handling etc etc.

This patch fixes this by making the AGP drivers use the new
set_memory_XX APIs instead.

Note: amd-k7-agp.c is built on Alpha too, and generic.c is built
on ia64 as well, which do not yet have the set_memory_*() APIs,
so for them some we have a few ugly #ifdefs - hopefully they'll
be fixed soon.

Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Dave Airlie <airlied@linux.ie>
arch/x86/mm/ioremap.c
drivers/char/agp/amd-k7-agp.c
drivers/char/agp/ati-agp.c
drivers/char/agp/generic.c
drivers/char/agp/sworks-agp.c