]> www.pilppa.org Git - linux-2.6-omap-h63xx.git/commit
net/bridge/netfilter: move a dereference below a NULL test
authorJulia Lawall <julia@diku.dk>
Fri, 9 Jan 2009 10:22:22 +0000 (10:22 +0000)
committerDavid S. Miller <davem@davemloft.net>
Sun, 11 Jan 2009 08:06:33 +0000 (00:06 -0800)
commitf3d8b2e467da7a9237a45248ff03b56b6a7c3df7
tree352fcff7f85e95a3bf512d820b4fe7c483e79643
parent6c614a50206ee56c21b34cc02d0bd40e756db87e
net/bridge/netfilter: move a dereference below a NULL test

In each case, if the NULL test is necessary, then the dereference should be
moved below the NULL test.

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@@
type T;
expression E;
identifier i,fld;
statement S;
@@

- T i = E->fld;
+ T i;
  ... when != E
      when != i
  if (E == NULL) S
+ i = E->fld;
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/bridge/netfilter/ebtables.c