]> www.pilppa.org Git - linux-2.6-omap-h63xx.git/commit
random: make mixing interface byte-oriented
authorMatt Mackall <mpm@selenic.com>
Tue, 29 Apr 2008 08:03:05 +0000 (01:03 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Tue, 29 Apr 2008 15:06:25 +0000 (08:06 -0700)
commite68e5b664ecb9bccf68102557107a6b6d739a97c
treef74a1d9585295463f166fdcffcc8e28527728b1a
parent993ba2114c554c1561a018e5c63a771ec8e1c469
random: make mixing interface byte-oriented

Switch add_entropy_words to a byte-oriented interface, eliminating numerous
casts and byte/word size rounding issues.  This also reduces the overall
bit/byte/word confusion in this code.

We now mix a byte at a time into the word-based pool.  This takes four times
as many iterations, but should be negligible compared to hashing overhead.
This also increases our pool churn, which adds some depth against some
theoretical failure modes.

The function name is changed to emphasize pool mixing and deemphasize entropy
(the samples mixed in may not contain any).  extract is added to the core
function to make it clear that it extracts from the pool.

Signed-off-by: Matt Mackall <mpm@selenic.com>
Cc: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/char/random.c