]> www.pilppa.org Git - linux-2.6-omap-h63xx.git/commit
[PARISC] Fix double free when removing HIL drivers
authorKyle McMartin <kyle@parisc-linux.org>
Thu, 30 Mar 2006 16:47:32 +0000 (11:47 -0500)
committerKyle McMartin <kyle@hera.kernel.org>
Thu, 30 Mar 2006 17:48:59 +0000 (17:48 +0000)
commitcd7a9202a5a6e7712df2b80ed5ebd7b078130fc3
treec7e2504dd6de0d2412815dce658468f7add77173
parent4da9f131a74d12de56c44da6d522a9116da06805
[PARISC] Fix double free when removing HIL drivers

On Thu, Mar 30, 2006 at 08:31:02AM -0500, Dmitry Torokhov wrote:
> Don't do that, its double free. input_unregister_device() normally
> causes release() to be called and free the device. input_free_device
> is only to be called when input_register_device has not been called or
> failed.
>
> Plus you might want to unregister device after closing serio port,
> otherwise your interrupt routine might be referencing already freed
> memory.

Signed-off-by: Kyle McMartin <kyle@parisc-linux.org>
drivers/input/keyboard/hil_kbd.c
drivers/input/keyboard/hilkbd.c
drivers/input/mouse/hil_ptr.c