]> www.pilppa.org Git - linux-2.6-omap-h63xx.git/commit
locking, hpet: annotate false positive warning
authorPeter Zijlstra <peterz@infradead.org>
Mon, 12 Jan 2009 11:52:23 +0000 (12:52 +0100)
committerIngo Molnar <mingo@elte.hu>
Mon, 12 Jan 2009 12:33:20 +0000 (13:33 +0100)
commit6d612b0f943289856c6e8186c564cda922cd040e
tree8753222989421a00828c7f4d2fc276021a453263
parent783adf42cf039083dd3c734c07c3bdc707e2bb15
locking, hpet: annotate false positive warning

Alexander Beregalov reported that this warning is caused by the HPET code:

> hpet0: at MMIO 0xfed00000, IRQs 2, 8, 0
> hpet0: 3 comparators, 64-bit 14.318180 MHz counter
> ODEBUG: object is on stack, but not annotated
> ------------[ cut here ]------------
> WARNING: at lib/debugobjects.c:251 __debug_object_init+0x2a4/0x352()

> Bisected down to 26afe5f2fbf06ea0765aaa316640c4dd472310c0
> (x86: HPET_MSI Initialise per-cpu HPET timers)

The commit is fine - but the on-stack workqueue entry needs annotation.

Reported-and-bisected-by: Alexander Beregalov <a.beregalov@gmail.com>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Tested-by: Alexander Beregalov <a.beregalov@gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
arch/x86/kernel/hpet.c
include/linux/workqueue.h