]> www.pilppa.org Git - linux-2.6-omap-h63xx.git/commit
projects / linux-2.6-omap-h63xx.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: c751e4f) | patch
netrom: Kill spurious NULL'ing of sk->sk_socket.
authorDavid S. Miller <davem@davemloft.net>
Tue, 17 Jun 2008 10:19:58 +0000 (03:19 -0700)
committerDavid S. Miller <davem@davemloft.net>
Tue, 17 Jun 2008 10:19:58 +0000 (03:19 -0700)
commit48c5732f4ac0621a2fdde006d55a6621a47a728f
treeb43f467850edc019cc8537bbc2495c8740b4c251tree | snapshot
parentc751e4f8b32a3869bb4fec12100952abd9baa0e1commit | diff
netrom: Kill spurious NULL'ing of sk->sk_socket.

In nr_release(), one code path calls sock_orphan() which
will NULL out sk->sk_socket already.

In the other case, handling states other than NR_STATE_{0,1,2,3},
seems to not be possible other than due to bugs.  Even for an
uninitialized nr->state value, that would be zero or NR_STATE_0.
It might be wise to stick a WARN_ON() here.

Signed-off-by: David S. Miller <davem@davemloft.net>
net/netrom/af_netrom.c diff | blob | history
Unnamed repository; edit this file 'description' to name the repository.