]> www.pilppa.org Git - linux-2.6-omap-h63xx.git/commit
[TCP]: Fix fastpath_cnt_hint when GSO skb is partially ACKed
authorIlpo Järvinen <ilpo.jarvinen@helsinki.fi>
Mon, 8 Oct 2007 06:43:10 +0000 (23:43 -0700)
committerDavid S. Miller <davem@davemloft.net>
Mon, 8 Oct 2007 06:43:10 +0000 (23:43 -0700)
commit48611c47d09023d9356e78550d1cadb8d61da9c8
tree1e118a43db7143f8091b5b0a95e6d6f85dc5b2f9
parent3eb215de26e6e94bf5fed9cb77230c383b30e53b
[TCP]: Fix fastpath_cnt_hint when GSO skb is partially ACKed

When only GSO skb was partially ACKed, no hints are reset,
therefore fastpath_cnt_hint must be tweaked too or else it can
corrupt fackets_out. The corruption to occur, one must have
non-trivial ACK/SACK sequence, so this bug is not very often
that harmful. There's a fackets_out state reset in TCP because
fackets_out is known to be inaccurate and that fixes the issue
eventually anyway.

In case there was also at least one skb that got fully ACKed,
the fastpath_skb_hint is set to NULL which causes a recount for
fastpath_cnt_hint (the old value won't be accessed anymore),
thus it can safely be decremented without additional checking.

Reported by Cedric Le Goater <clg@fr.ibm.com>

Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/tcp_input.c