]> www.pilppa.org Git - linux-2.6-omap-h63xx.git/commit
[PATCH] libata: fix autopsy ehc->i.action and ehc->i.dev handling
authorTejun Heo <htejun@gmail.com>
Sat, 8 Jul 2006 11:17:26 +0000 (20:17 +0900)
committerJeff Garzik <jeff@garzik.org>
Wed, 19 Jul 2006 18:06:53 +0000 (14:06 -0400)
commit4528e4da79675b4995e085046b8ffbe0415c3261
tree9ddea7e2229a282879212ba9d4ba16f0e0a27955
parentf5beec49636bf8d5a34065c8ab030cd4ea84516f
[PATCH] libata: fix autopsy ehc->i.action and ehc->i.dev handling

Commit 0662c58b3265f52f708a6d59476bc7862b01f9c0 updated
ata_eh_autopsy() to OR determined action to ehc->i.action to preserve
action mask set directly into ehc->i.action by nested functions.  This
broke action mask clearing on SENSE_VALID case causing revalidation
and EH complete message on successful ATAPI CC.

This patch removes two local variables - action and failed_dev - which
cache ehc->i.action and ehc->i.dev respectively, and make the function
directly modify ehc->i.* fields to remove aliasing issues.

Signed-off-by: Tejun Heo <htejun@gmail.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
drivers/scsi/libata-eh.c