]> www.pilppa.org Git - linux-2.6-omap-h63xx.git/blobdiff - fs/xfs/linux-2.6/xfs_iops.c
[XFS] Kill attr_capable checks as already done in xattr_permission.
[linux-2.6-omap-h63xx.git] / fs / xfs / linux-2.6 / xfs_iops.c
index 215158cbac439a901505fc36071bf5dc893a8660..13b6cfd366c22becaf62ab0c5198b577442ff193 100644 (file)
@@ -62,12 +62,11 @@ void
 xfs_synchronize_atime(
        xfs_inode_t     *ip)
 {
-       bhv_vnode_t     *vp;
+       struct inode    *inode = ip->i_vnode;
 
-       vp = XFS_ITOV_NULL(ip);
-       if (vp) {
-               ip->i_d.di_atime.t_sec = (__int32_t)vp->i_atime.tv_sec;
-               ip->i_d.di_atime.t_nsec = (__int32_t)vp->i_atime.tv_nsec;
+       if (inode) {
+               ip->i_d.di_atime.t_sec = (__int32_t)inode->i_atime.tv_sec;
+               ip->i_d.di_atime.t_nsec = (__int32_t)inode->i_atime.tv_nsec;
        }
 }
 
@@ -80,11 +79,10 @@ void
 xfs_mark_inode_dirty_sync(
        xfs_inode_t     *ip)
 {
-       bhv_vnode_t     *vp;
+       struct inode    *inode = ip->i_vnode;
 
-       vp = XFS_ITOV_NULL(ip);
-       if (vp)
-               mark_inode_dirty_sync(vn_to_inode(vp));
+       if (inode)
+               mark_inode_dirty_sync(inode);
 }
 
 /*
@@ -157,13 +155,6 @@ xfs_ichgtime_fast(
         */
        ASSERT((flags & XFS_ICHGTIME_ACC) == 0);
 
-       /*
-        * We're not supposed to change timestamps in readonly-mounted
-        * filesystems.  Throw it away if anyone asks us.
-        */
-       if (unlikely(IS_RDONLY(inode)))
-               return;
-
        if (flags & XFS_ICHGTIME_MOD) {
                tvp = &inode->i_mtime;
                ip->i_d.di_mtime.t_sec = (__int32_t)tvp->tv_sec;
@@ -215,54 +206,62 @@ xfs_validate_fields(
  */
 STATIC int
 xfs_init_security(
-       bhv_vnode_t     *vp,
+       struct inode    *inode,
        struct inode    *dir)
 {
-       struct inode    *ip = vn_to_inode(vp);
+       struct xfs_inode *ip = XFS_I(inode);
        size_t          length;
        void            *value;
        char            *name;
        int             error;
 
-       error = security_inode_init_security(ip, dir, &name, &value, &length);
+       error = security_inode_init_security(inode, dir, &name,
+                                            &value, &length);
        if (error) {
                if (error == -EOPNOTSUPP)
                        return 0;
                return -error;
        }
 
-       error = xfs_attr_set(XFS_I(ip), name, value,
-                       length, ATTR_SECURE);
+       error = xfs_attr_set(ip, name, value, length, ATTR_SECURE);
        if (!error)
-               xfs_iflags_set(XFS_I(ip), XFS_IMODIFIED);
+               xfs_iflags_set(ip, XFS_IMODIFIED);
 
        kfree(name);
        kfree(value);
        return error;
 }
 
+static void
+xfs_dentry_to_name(
+       struct xfs_name *namep,
+       struct dentry   *dentry)
+{
+       namep->name = dentry->d_name.name;
+       namep->len = dentry->d_name.len;
+}
+
 STATIC void
 xfs_cleanup_inode(
        struct inode    *dir,
-       bhv_vnode_t     *vp,
+       struct inode    *inode,
        struct dentry   *dentry,
        int             mode)
 {
-       struct dentry   teardown = {};
+       struct xfs_name teardown;
 
        /* Oh, the horror.
         * If we can't add the ACL or we fail in
         * xfs_init_security we must back out.
         * ENOSPC can hit here, among other things.
         */
-       teardown.d_inode = vn_to_inode(vp);
-       teardown.d_name = dentry->d_name;
+       xfs_dentry_to_name(&teardown, dentry);
 
        if (S_ISDIR(mode))
-               xfs_rmdir(XFS_I(dir), &teardown);
+               xfs_rmdir(XFS_I(dir), &teardown, XFS_I(inode));
        else
-               xfs_remove(XFS_I(dir), &teardown);
-       VN_RELE(vp);
+               xfs_remove(XFS_I(dir), &teardown, XFS_I(inode));
+       iput(inode);
 }
 
 STATIC int
@@ -275,6 +274,7 @@ xfs_vn_mknod(
        struct inode    *inode;
        struct xfs_inode *ip = NULL;
        xfs_acl_t       *default_acl = NULL;
+       struct xfs_name name;
        attrexists_t    test_default_acl = _ACL_DEFAULT_EXISTS;
        int             error;
 
@@ -295,6 +295,8 @@ xfs_vn_mknod(
                }
        }
 
+       xfs_dentry_to_name(&name, dentry);
+
        if (IS_POSIXACL(dir) && !default_acl)
                mode &= ~current->fs->umask;
 
@@ -305,10 +307,10 @@ xfs_vn_mknod(
        case S_IFSOCK:
                rdev = sysv_encode_dev(rdev);
        case S_IFREG:
-               error = xfs_create(XFS_I(dir), dentry, mode, rdev, &ip, NULL);
+               error = xfs_create(XFS_I(dir), &name, mode, rdev, &ip, NULL);
                break;
        case S_IFDIR:
-               error = xfs_mkdir(XFS_I(dir), dentry, mode, &ip, NULL);
+               error = xfs_mkdir(XFS_I(dir), &name, mode, &ip, NULL);
                break;
        default:
                error = EINVAL;
@@ -372,13 +374,15 @@ xfs_vn_lookup(
        struct dentry   *dentry,
        struct nameidata *nd)
 {
-       bhv_vnode_t     *cvp;
+       struct xfs_inode *cip;
+       struct xfs_name name;
        int             error;
 
        if (dentry->d_name.len >= MAXNAMELEN)
                return ERR_PTR(-ENAMETOOLONG);
 
-       error = xfs_lookup(XFS_I(dir), dentry, &cvp);
+       xfs_dentry_to_name(&name, dentry);
+       error = xfs_lookup(XFS_I(dir), &name, &cip);
        if (unlikely(error)) {
                if (unlikely(error != ENOENT))
                        return ERR_PTR(-error);
@@ -386,7 +390,7 @@ xfs_vn_lookup(
                return NULL;
        }
 
-       return d_splice_alias(vn_to_inode(cvp), dentry);
+       return d_splice_alias(cip->i_vnode, dentry);
 }
 
 STATIC int
@@ -396,12 +400,14 @@ xfs_vn_link(
        struct dentry   *dentry)
 {
        struct inode    *inode; /* inode of guy being linked to */
+       struct xfs_name name;
        int             error;
 
        inode = old_dentry->d_inode;
+       xfs_dentry_to_name(&name, dentry);
 
        igrab(inode);
-       error = xfs_link(XFS_I(dir), XFS_I(inode), dentry);
+       error = xfs_link(XFS_I(dir), XFS_I(inode), &name);
        if (unlikely(error)) {
                iput(inode);
                return -error;
@@ -419,11 +425,13 @@ xfs_vn_unlink(
        struct dentry   *dentry)
 {
        struct inode    *inode;
+       struct xfs_name name;
        int             error;
 
        inode = dentry->d_inode;
+       xfs_dentry_to_name(&name, dentry);
 
-       error = xfs_remove(XFS_I(dir), dentry);
+       error = xfs_remove(XFS_I(dir), &name, XFS_I(inode));
        if (likely(!error)) {
                xfs_validate_fields(dir);       /* size needs update */
                xfs_validate_fields(inode);
@@ -439,14 +447,15 @@ xfs_vn_symlink(
 {
        struct inode    *inode;
        struct xfs_inode *cip = NULL;
+       struct xfs_name name;
        int             error;
        mode_t          mode;
 
        mode = S_IFLNK |
                (irix_symlink_mode ? 0777 & ~current->fs->umask : S_IRWXUGO);
+       xfs_dentry_to_name(&name, dentry);
 
-       error = xfs_symlink(XFS_I(dir), dentry, (char *)symname, mode,
-                           &cip, NULL);
+       error = xfs_symlink(XFS_I(dir), &name, symname, mode, &cip, NULL);
        if (unlikely(error))
                goto out;
 
@@ -473,9 +482,12 @@ xfs_vn_rmdir(
        struct dentry   *dentry)
 {
        struct inode    *inode = dentry->d_inode;
+       struct xfs_name name;
        int             error;
 
-       error = xfs_rmdir(XFS_I(dir), dentry);
+       xfs_dentry_to_name(&name, dentry);
+
+       error = xfs_rmdir(XFS_I(dir), &name, XFS_I(inode));
        if (likely(!error)) {
                xfs_validate_fields(inode);
                xfs_validate_fields(dir);
@@ -491,9 +503,16 @@ xfs_vn_rename(
        struct dentry   *ndentry)
 {
        struct inode    *new_inode = ndentry->d_inode;
+       struct xfs_name oname;
+       struct xfs_name nname;
        int             error;
 
-       error = xfs_rename(XFS_I(odir), odentry, XFS_I(ndir), ndentry);
+       xfs_dentry_to_name(&oname, odentry);
+       xfs_dentry_to_name(&nname, ndentry);
+
+       error = xfs_rename(XFS_I(odir), &oname, XFS_I(odentry->d_inode),
+                          XFS_I(ndir), &nname, new_inode ?
+                                               XFS_I(new_inode) : NULL);
        if (likely(!error)) {
                if (new_inode)
                        xfs_validate_fields(new_inode);
@@ -570,8 +589,7 @@ xfs_check_acl(
 STATIC int
 xfs_vn_permission(
        struct inode            *inode,
-       int                     mask,
-       struct nameidata        *nd)
+       int                     mask)
 {
        return generic_permission(inode, mask, xfs_check_acl);
 }
@@ -694,11 +712,19 @@ xfs_vn_setattr(
        return -error;
 }
 
+/*
+ * block_truncate_page can return an error, but we can't propagate it
+ * at all here. Leave a complaint + stack trace in the syslog because
+ * this could be bad. If it is bad, we need to propagate the error further.
+ */
 STATIC void
 xfs_vn_truncate(
        struct inode    *inode)
 {
-       block_truncate_page(inode->i_mapping, inode->i_size, xfs_get_blocks);
+       int     error;
+       error = block_truncate_page(inode->i_mapping, inode->i_size,
+                                                       xfs_get_blocks);
+       WARN_ON(error);
 }
 
 STATIC int
@@ -713,15 +739,11 @@ xfs_vn_setxattr(
        char            *attr = (char *)name;
        attrnames_t     *namesp;
        int             xflags = 0;
-       int             error;
 
        namesp = attr_lookup_namespace(attr, attr_namespaces, ATTR_NAMECOUNT);
        if (!namesp)
                return -EOPNOTSUPP;
        attr += namesp->attr_namelen;
-       error = namesp->attr_capable(vp, NULL);
-       if (error)
-               return error;
 
        /* Convert Linux syscall to XFS internal ATTR flags */
        if (flags & XATTR_CREATE)
@@ -743,15 +765,11 @@ xfs_vn_getxattr(
        char            *attr = (char *)name;
        attrnames_t     *namesp;
        int             xflags = 0;
-       ssize_t         error;
 
        namesp = attr_lookup_namespace(attr, attr_namespaces, ATTR_NAMECOUNT);
        if (!namesp)
                return -EOPNOTSUPP;
        attr += namesp->attr_namelen;
-       error = namesp->attr_capable(vp, NULL);
-       if (error)
-               return error;
 
        /* Convert Linux syscall to XFS internal ATTR flags */
        if (!size) {
@@ -791,15 +809,12 @@ xfs_vn_removexattr(
        char            *attr = (char *)name;
        attrnames_t     *namesp;
        int             xflags = 0;
-       int             error;
 
        namesp = attr_lookup_namespace(attr, attr_namespaces, ATTR_NAMECOUNT);
        if (!namesp)
                return -EOPNOTSUPP;
        attr += namesp->attr_namelen;
-       error = namesp->attr_capable(vp, NULL);
-       if (error)
-               return error;
+
        xflags |= namesp->attr_flag;
        return namesp->attr_remove(vp, attr, xflags);
 }