* drivers/input/keyboard/omap-twl4030keypad.c
*
* Copyright (C) 2007 Texas Instruments, Inc.
+ * Copyright (C) 2008 Nokia Corporation
*
* Code re-written for 2430SDP by:
* Syed Mohammed Khasim <x0khasim@ti.com>
#include <linux/types.h>
#include <linux/input.h>
#include <linux/kernel.h>
+#include <linux/mutex.h>
#include <linux/delay.h>
+#include <linux/bitops.h>
#include <linux/platform_device.h>
#include <linux/i2c.h>
#include <linux/i2c/twl4030.h>
-#include <asm/irq.h>
-#include <asm/arch/keypad.h>
+#include <linux/irq.h>
#include "twl4030-keypad.h"
-#define OMAP_TWL4030KP_LOG_LEVEL 0
+#define PTV_PRESCALER 4
-#define KEY(col, row, val) (((col) << 28) | ((row) << 24) | (val))
-#define NUM_ROWS 5
-#define NUM_COLS 6
+#define MAX_ROWS 8 /* TWL4030 hardlimit */
+#define ROWCOL_MASK 0xFF000000
+#define KEYNUM_MASK 0x00FFFFFF
+#define KEY(col, row, val) (((col) << 28) | ((row) << 24) | (val))
-#define ROW_MASK ((1<<NUM_ROWS)-1)
+/* Global variables */
+
+struct omap_keypad {
+ int *keymap;
+ unsigned int keymapsize;
+ u16 kp_state[MAX_ROWS];
+ int n_rows;
+ int n_cols;
+ int irq;
-#define SCAN_RATE HZ/20
-#define KEYNUM_MASK 0xFF000000
-#define ROWCOL_MASK 0x00FFFFFF
+ struct device *dbg_dev;
+ struct input_dev *omap_twl4030kp;
-static char *switch_name[NUM_ROWS][NUM_COLS] = {
- {"S2_L", "S2_D", "S2_S", "S3", "S4", "S23"},
- {"S2_R", "S2_U", "S5", "S6", "S7", "S24"},
- {"S8", "S9", "S10", "S11", "S12", "S25"},
- {"S13", "S14", "S15", "S16", "S17", "S26"},
- {"S18", "S19", "S20", "S21", "S22", "S27"},
+ /* sync read/write */
+ struct mutex mutex;
};
-/* Global variables */
-static int *keymap;
-static unsigned char kp_state[NUM_ROWS];
-static struct device * dbg_dev;
-
-/* Function Templates */
-static struct input_dev *omap_twl4030kp;
-struct timer_list kptimer;
-static void omap_kp_timer(unsigned long);
-static void twl4030_kp_scan(void);
-struct work_struct timer_work;
-static void twl4030_timer_work(struct work_struct *unused);
-
-static int twl4030_kpread_u8(u32 module, u8 * data, u32 reg)
+static int twl4030_kpread(struct omap_keypad *kp,
+ u32 module, u8 *data, u32 reg, u8 num_bytes)
{
int ret;
- ret = twl4030_i2c_read_u8(module, data, reg);
+ ret = twl4030_i2c_read(module, data, reg, num_bytes);
if (ret < 0) {
- dev_warn(dbg_dev, "Couldn't read TWL4030 register %X - ret %d[%x]\n",
+ dev_warn(kp->dbg_dev,
+ "Couldn't read TWL4030: %X - ret %d[%x]\n",
reg, ret, ret);
return ret;
}
return ret;
}
-static int twl4030_kpwrite_u8(u32 module, u8 data, u32 reg)
+static int twl4030_kpwrite_u8(struct omap_keypad *kp,
+ u32 module, u8 data, u32 reg)
{
int ret;
ret = twl4030_i2c_write_u8(module, data, reg);
if (ret < 0) {
- dev_warn(dbg_dev, "Could not write TWL4030 register %X - ret %d[%x]\n",
+ dev_warn(kp->dbg_dev,
+ "Could not write TWL4030: %X - ret %d[%x]\n",
reg, ret, ret);
return ret;
}
return ret;
}
-static inline int omap_kp_find_key(int col, int row)
+static int omap_kp_find_key(struct omap_keypad *kp, int col, int row)
{
- int i, key;
+ int i, rc;
- key = KEY(col, row, 0);
- for (i = 0; keymap[i] != 0; i++)
- if ((keymap[i] & KEYNUM_MASK) == key)
- return keymap[i] & ROWCOL_MASK;
+ rc = KEY(col, row, 0);
+ for (i = 0; i < kp->keymapsize; i++)
+ if ((kp->keymap[i] & ROWCOL_MASK) == rc)
+ return kp->keymap[i] & KEYNUM_MASK;
return -EINVAL;
}
-static void twl4030_kp_scan(void)
+static inline u16 omap_kp_col_xlate(struct omap_keypad *kp, u8 col)
{
- unsigned char new_state[NUM_ROWS], changed, key_down = 0;
- u8 col, row, spurious = 0;
- u8 code_reg = REG_FULL_CODE_7_0;
- int ret;
+ /* If all bits in a row are active for all coloumns then
+ * we have that row line connected to gnd. Mark this
+ * key on as if it was on matrix position n_cols (ie
+ * one higher than the size of the matrix).
+ */
+ if (col == 0xFF)
+ return 1 << kp->n_cols;
+ else
+ return col & ((1 << kp->n_cols) - 1);
+}
- /* check for any changes */
- ret =
- twl4030_i2c_read(TWL4030_MODULE_KEYPAD, new_state, code_reg,
- NUM_ROWS);
- if (ret < 0)
- dev_warn(dbg_dev, "Could not read TWL4030 register %X - ret %d[%x]\n",
- code_reg, ret, ret);
+static int omap_kp_read_kp_matrix_state(struct omap_keypad *kp, u16 *state)
+{
+ u8 new_state[MAX_ROWS];
+ int row;
+ int ret = twl4030_kpread(kp, TWL4030_MODULE_KEYPAD,
+ new_state, KEYP_FULL_CODE_7_0, kp->n_rows);
+ if (ret >= 0) {
+ for (row = 0; row < kp->n_rows; row++)
+ state[row] = omap_kp_col_xlate(kp, new_state[row]);
+ }
+ return ret;
+}
+
+static int omap_kp_is_in_ghost_state(struct omap_keypad *kp, u16 *key_state)
+{
+ int i;
+ u16 check = 0;
+
+ for (i = 0; i < kp->n_rows; i++) {
+ u16 col = key_state[i];
+
+ if ((col & check) && hweight16(col) > 1)
+ return 1;
+ check |= col;
+ }
+
+ return 0;
+}
+
+static void twl4030_kp_scan(struct omap_keypad *kp, int release_all)
+{
+ u16 new_state[MAX_ROWS];
+ int col, row;
+
+ if (release_all)
+ memset(new_state, 0, sizeof(new_state));
+ else {
+ /* check for any changes */
+ int ret = omap_kp_read_kp_matrix_state(kp, new_state);
+ if (ret < 0) /* panic ... */
+ return;
+
+ if (omap_kp_is_in_ghost_state(kp, new_state))
+ return;
+ }
+
+ mutex_lock(&kp->mutex);
/* check for changes and print those */
- for (row = 0; row < NUM_ROWS; row++) {
- changed = new_state[row] ^ kp_state[row];
- key_down |= new_state[row];
+ for (row = 0; row < kp->n_rows; row++) {
+ int changed = new_state[row] ^ kp->kp_state[row];
- if (changed == 0)
+ if (!changed)
continue;
- for (col = 0; col < NUM_COLS; col++) {
+ for (col = 0; col < kp->n_cols + 1; col++) {
int key;
if (!(changed & (1 << col)))
continue;
- dev_dbg(dbg_dev, "key %s %s\n", switch_name[row][col],
+ dev_dbg(kp->dbg_dev, "key [%d:%d] %s\n", row, col,
(new_state[row] & (1 << col)) ?
"press" : "release");
- key = omap_kp_find_key(col, row);
- if (key < 0) {
- dev_warn(dbg_dev, "omap-kp: Spurious key event %d-%d\n",
+ key = omap_kp_find_key(kp, col, row);
+ if (key < 0)
+ dev_warn(kp->dbg_dev,
+ "Spurious key event %d-%d\n",
col, row);
- /* We scan again after a couple of seconds */
- spurious = 1;
- continue;
- }
- input_report_key(omap_twl4030kp, key,
- new_state[row] & (1 << col));
+ else
+ input_report_key(kp->omap_twl4030kp, key,
+ new_state[row] & (1 << col));
}
+ kp->kp_state[row] = new_state[row];
}
- if (key_down) {
- /*
- * some key is pressed - keep irq disabled and use timer
- * to poll for key release
- */
- if (spurious)
- mod_timer(&kptimer, jiffies + SCAN_RATE * 2);
- else
- mod_timer(&kptimer, jiffies + SCAN_RATE);
- }
- memcpy(kp_state, new_state, sizeof(kp_state));
-}
-static void twl4030_timer_work(struct work_struct *unused)
-{
- twl4030_kp_scan();
-}
-
-void omap_kp_timer(unsigned long data)
-{
- schedule_work(&timer_work);
+ mutex_unlock(&kp->mutex);
}
/*
* Keypad interrupt handler
*/
-static irqreturn_t do_kp_irq(int irq, void *dev_id)
+static irqreturn_t do_kp_irq(int irq, void *_kp)
{
+ struct omap_keypad *kp = _kp;
u8 reg;
int ret;
- /* Mask keypad interrupts */
- reg = KEYP_IMR1_MASK;
- ret = twl4030_kpwrite_u8(TWL4030_MODULE_KEYPAD, reg, REG_KEYP_IMR1);
-
- /*
- * Scan keypad for any changes
- * in keypad matrix.
+#ifdef CONFIG_LOCKDEP
+ /* WORKAROUND for lockdep forcing IRQF_DISABLED on us, which
+ * we don't want and can't tolerate. Although it might be
+ * friendlier not to borrow this thread context...
*/
- twl4030_kp_scan();
+ local_irq_enable();
+#endif
- /* Clear TWL4030 PIH interrupt */
- ret = twl4030_kpread_u8(TWL4030_MODULE_KEYPAD, ®, REG_KEYP_ISR1);
+ /* Read & Clear TWL4030 pending interrupt */
+ ret = twl4030_kpread(kp, TWL4030_MODULE_KEYPAD, ®, KEYP_ISR1, 1);
- /* Enable interrupts */
- reg = KEYP_IMR1_UNMASK;
- ret = twl4030_kpwrite_u8(TWL4030_MODULE_KEYPAD, reg, REG_KEYP_IMR1);
+ /* Release all keys if I2C has gone bad or
+ * the KEYP has gone to idle state */
+ if ((ret >= 0) && (reg & KEYP_IMR1_KP))
+ twl4030_kp_scan(kp, 0);
+ else
+ twl4030_kp_scan(kp, 1);
return IRQ_HANDLED;
}
/*
* Registers keypad device with input sub system
* and configures TWL4030 keypad registers
- *
*/
static int __init omap_kp_probe(struct platform_device *pdev)
{
- u8 reg, i;
- u8 code_reg = REG_FULL_CODE_7_0;
+ u8 reg;
+ int i;
int ret = 0;
- struct omap_kp_platform_data *pdata = pdev->dev.platform_data;
+ struct omap_keypad *kp;
+ struct twl4030_keypad_data *pdata = pdev->dev.platform_data;
- /* Get the debug Device */
- dbg_dev = &(pdev->dev);
+ kp = kzalloc(sizeof(*kp), GFP_KERNEL);
+ if (!kp)
+ return -ENOMEM;
if (!pdata->rows || !pdata->cols || !pdata->keymap) {
- dev_err(dbg_dev, "No rows, cols or keymap from pdata\n");
+ dev_err(&pdev->dev, "No rows, cols or keymap from pdata\n");
+ kfree(kp);
return -EINVAL;
}
- omap_twl4030kp = input_allocate_device();
- if (omap_twl4030kp == NULL)
+ dev_set_drvdata(&pdev->dev, kp);
+
+ /* Get the debug Device */
+ kp->dbg_dev = &pdev->dev;
+
+ kp->omap_twl4030kp = input_allocate_device();
+ if (!kp->omap_twl4030kp) {
+ kfree(kp);
return -ENOMEM;
+ }
- keymap = pdata->keymap;
+ mutex_init(&kp->mutex);
+
+ kp->keymap = pdata->keymap;
+ kp->keymapsize = pdata->keymapsize;
+ kp->n_rows = pdata->rows;
+ kp->n_cols = pdata->cols;
+ kp->irq = pdata->irq;
/* setup input device */
- set_bit(EV_KEY, omap_twl4030kp->evbit);
+ set_bit(EV_KEY, kp->omap_twl4030kp->evbit);
/* Enable auto repeat feature of Linux input subsystem */
- set_bit(EV_REP, omap_twl4030kp->evbit);
+ if (pdata->rep)
+ set_bit(EV_REP, kp->omap_twl4030kp->evbit);
- for (i = 0; keymap[i] != 0; i++)
- set_bit(keymap[i] & 0x00ffffff, omap_twl4030kp->keybit);
+ for (i = 0; i < kp->keymapsize; i++)
+ set_bit(kp->keymap[i] & KEYNUM_MASK,
+ kp->omap_twl4030kp->keybit);
- omap_twl4030kp->name = "omap_twl4030keypad";
- omap_twl4030kp->phys = "omap_twl4030keypad/input0";
- omap_twl4030kp->dev.parent = &pdev->dev;
+ kp->omap_twl4030kp->name = "omap_twl4030keypad";
+ kp->omap_twl4030kp->phys = "omap_twl4030keypad/input0";
+ kp->omap_twl4030kp->dev.parent = &pdev->dev;
- omap_twl4030kp->id.bustype = BUS_HOST;
- omap_twl4030kp->id.vendor = 0x0001;
- omap_twl4030kp->id.product = 0x0001;
- omap_twl4030kp->id.version = 0x0003;
+ kp->omap_twl4030kp->id.bustype = BUS_HOST;
+ kp->omap_twl4030kp->id.vendor = 0x0001;
+ kp->omap_twl4030kp->id.product = 0x0001;
+ kp->omap_twl4030kp->id.version = 0x0003;
- omap_twl4030kp->keycode = keymap;
- omap_twl4030kp->keycodesize = sizeof(unsigned int);
- omap_twl4030kp->keycodemax = pdata->keymapsize;
+ kp->omap_twl4030kp->keycode = kp->keymap;
+ kp->omap_twl4030kp->keycodesize = sizeof(unsigned int);
+ kp->omap_twl4030kp->keycodemax = kp->keymapsize;
- ret = input_register_device(omap_twl4030kp);
+ ret = input_register_device(kp->omap_twl4030kp);
if (ret < 0) {
- dev_err(dbg_dev, "Unable to register twl4030 keypad device\n");
+ dev_err(kp->dbg_dev,
+ "Unable to register twl4030 keypad device\n");
goto err2;
}
- setup_timer(&kptimer,omap_kp_timer,(unsigned long) omap_twl4030kp);
-
- /*
- * Since keypad driver uses I2C for reading
- * twl4030 keypad registers, tasklets cannot
- * be used.
- */
- INIT_WORK(&timer_work, twl4030_timer_work);
+ /* Disable auto-repeat */
+ reg = KEYP_CTRL_NOAUTORPT;
+ ret = twl4030_kpwrite_u8(kp, TWL4030_MODULE_KEYPAD, reg, KEYP_CTRL);
+ if (ret < 0)
+ goto err3;
- reg = KEYP_CTRL_REG_MASK_NOAUTORPT;
- ret = twl4030_kpwrite_u8(TWL4030_MODULE_KEYPAD, reg,
- REG_KEYP_CTRL_REG);
+ /* Enable TO rising and KP rising and falling edge detection */
+ reg = KEYP_EDR_KP_BOTH | KEYP_EDR_TO_RISING;
+ ret = twl4030_kpwrite_u8(kp, TWL4030_MODULE_KEYPAD, reg, KEYP_EDR);
if (ret < 0)
goto err3;
- /* Set all events to Falling Edge detection */
- reg = KEYP_EDR_MASK;
- ret = twl4030_kpwrite_u8(TWL4030_MODULE_KEYPAD, reg, REG_KEYP_EDR);
+ /* Set PTV prescaler Field */
+ reg = (PTV_PRESCALER << KEYP_LK_PTV_PTV_SHIFT);
+ ret = twl4030_kpwrite_u8(kp, TWL4030_MODULE_KEYPAD, reg, KEYP_LK_PTV);
if (ret < 0)
goto err3;
- /* Set Pre Scalar Field PTV to 4 */
- reg = BIT_LK_PTV_REG_PTV_MASK & (BIT_PTV_REG_PTV4 << BIT_LK_PTV_REG_PTV);
+ /* Set key debounce time to 20 ms */
+ i = KEYP_PERIOD_US(20000, PTV_PRESCALER);
+ ret = twl4030_kpwrite_u8(kp, TWL4030_MODULE_KEYPAD, i, KEYP_DEB);
+ if (ret < 0)
+ goto err3;
- ret = twl4030_kpwrite_u8(TWL4030_MODULE_KEYPAD, reg, REG_LK_PTV_REG);
+ /* Set timeout period to 100 ms */
+ i = KEYP_PERIOD_US(200000, PTV_PRESCALER);
+ ret = twl4030_kpwrite_u8(kp, TWL4030_MODULE_KEYPAD,
+ (i & 0xFF), KEYP_TIMEOUT_L);
if (ret < 0)
goto err3;
- /*
- * Set key debounce time to 10 ms using equation
- * Tint = Tclk * (LOAD_TIM+1) * 2^(PTV+1)
- * Where Tclk = 31.25 us ( since kbd_if_clk is 32KHz)
- * PTV = 4 for all the operations.
- */
- ret = twl4030_kpwrite_u8(TWL4030_MODULE_KEYPAD, 0x3f,
- REG_KEY_DEB_REG);
+ ret = twl4030_kpwrite_u8(kp, TWL4030_MODULE_KEYPAD,
+ (i >> 8), KEYP_TIMEOUT_H);
if (ret < 0)
goto err3;
- /* Set SIH Ctrl register */
- reg = KEYP_SIH_CTRL_MASK;
- ret = twl4030_kpwrite_u8(TWL4030_MODULE_KEYPAD, reg,
- REG_KEYP_SIH_CTRL);
+ /* Enable Clear-on-Read */
+ reg = KEYP_SIH_CTRL_COR | KEYP_SIH_CTRL_PEND_DIS;
+ ret = twl4030_kpwrite_u8(kp, TWL4030_MODULE_KEYPAD,
+ reg, KEYP_SIH_CTRL);
if (ret < 0)
goto err3;
* This ISR will always execute in kernel thread context because of
* the need to access the TWL4030 over the I2C bus.
*/
- ret = request_irq(TWL4030_MODIRQ_KEYPAD, do_kp_irq,
- IRQF_DISABLED, "TWL4030 Keypad", omap_twl4030kp);
+ ret = request_irq(kp->irq, do_kp_irq, 0, pdev->name, kp);
if (ret < 0) {
- dev_info(dbg_dev, "request_irq failed for irq no=%d\n",
- TWL4030_MODIRQ_KEYPAD);
+ dev_info(kp->dbg_dev, "request_irq failed for irq no=%d\n",
+ kp->irq);
goto err3;
} else {
- /* Enable keypad module interrupts now. */
- reg = KEYP_IMR1_UNMASK;
- ret = twl4030_kpwrite_u8(TWL4030_MODULE_KEYPAD, reg,
- REG_KEYP_IMR1);
- if (ret < 0) {
- /* mask all events - dont care abt result */
- (void)twl4030_kpwrite_u8(TWL4030_MODULE_KEYPAD, 0xff,
- REG_KEYP_IMR1);
- goto err4;
- }
+ /* Enable KP and TO interrupts now. */
+ reg = ~(KEYP_IMR1_KP | KEYP_IMR1_TO);
+ ret = twl4030_kpwrite_u8(kp, TWL4030_MODULE_KEYPAD,
+ reg, KEYP_IMR1);
+ if (ret < 0)
+ goto err5;
}
- /* Read initial state of keypad matrix. */
- ret = twl4030_i2c_read(TWL4030_MODULE_KEYPAD, kp_state, code_reg,
- NUM_ROWS);
- if (ret < 0) {
- dev_warn(dbg_dev, "Could not read TWL4030 register %X - ret %d[%x]\n",
- reg, ret, ret);
+ ret = omap_kp_read_kp_matrix_state(kp, kp->kp_state);
+ if (ret < 0)
goto err4;
- }
- return (ret);
+
+ return ret;
+err5:
+ /* mask all events - we don't care about the result */
+ (void) twl4030_kpwrite_u8(kp, TWL4030_MODULE_KEYPAD, 0xff, KEYP_IMR1);
err4:
- free_irq(TWL4030_MODIRQ_KEYPAD, NULL);
+ free_irq(kp->irq, NULL);
err3:
- input_unregister_device(omap_twl4030kp);
+ input_unregister_device(kp->omap_twl4030kp);
err2:
- input_free_device(omap_twl4030kp);
+ input_free_device(kp->omap_twl4030kp);
+
return -ENODEV;
}
static int omap_kp_remove(struct platform_device *pdev)
{
- free_irq(TWL4030_MODIRQ_KEYPAD, NULL);
- del_timer_sync(&kptimer);
+ struct omap_keypad *kp = dev_get_drvdata(&pdev->dev);
+
+ free_irq(kp->irq, kp);
+ input_unregister_device(kp->omap_twl4030kp);
+ kfree(kp);
- input_unregister_device(omap_twl4030kp);
return 0;
}
static struct platform_driver omap_kp_driver = {
.probe = omap_kp_probe,
- .remove = omap_kp_remove,
+ .remove = __devexit_p(omap_kp_remove),
.driver = {
- .name = "omap_twl4030keypad",
+ .name = "twl4030_keypad",
+ .owner = THIS_MODULE,
},
};
module_init(omap_kp_init);
module_exit(omap_kp_exit);
+MODULE_ALIAS("platform:twl4030_keypad");
MODULE_AUTHOR("Texas Instruments");
MODULE_DESCRIPTION("OMAP TWL4030 Keypad Driver");
MODULE_LICENSE("GPL");
projects / linux-2.6-omap-h63xx.git / blobdiff