]> www.pilppa.org Git - linux-2.6-omap-h63xx.git/blobdiff - drivers/ide/ide-floppy.c
ide-{floppy,tape}: remove packet command stack
[linux-2.6-omap-h63xx.git] / drivers / ide / ide-floppy.c
index ace6f26a296ad81d853398fb786dd5a35aa84eba..58cd6e6c687dd32944889bfa301c9596bd66cec3 100644 (file)
@@ -36,6 +36,7 @@
 #include <linux/hdreg.h>
 #include <linux/bitops.h>
 #include <linux/mutex.h>
+#include <linux/scatterlist.h>
 
 #include <scsi/scsi_ioctl.h>
 
  */
 #define IDEFLOPPY_PC_BUFFER_SIZE       256
 
-/*
- * In various places in the driver, we need to allocate storage for packet
- * commands and requests, which will remain valid while        we leave the driver to
- * wait for an interrupt or a timeout event.
- */
-#define IDEFLOPPY_PC_STACK             (10 + IDEFLOPPY_MAX_PC_RETRIES)
-
 /* format capacities descriptor codes */
 #define CAPACITY_INVALID       0x00
 #define CAPACITY_UNFORMATTED   0x01
@@ -103,13 +97,11 @@ typedef struct ide_floppy_obj {
        struct ide_atapi_pc *pc;
        /* Last failed packet command */
        struct ide_atapi_pc *failed_pc;
-       /* Packet command stack */
-       struct ide_atapi_pc pc_stack[IDEFLOPPY_PC_STACK];
-       /* Next free packet command storage space */
-       int pc_stack_index;
-       struct request rq_stack[IDEFLOPPY_PC_STACK];
-       /* We implement a circular array */
-       int rq_stack_index;
+       /* used for blk_{fs,pc}_request() requests */
+       struct ide_atapi_pc queued_pc;
+
+       struct ide_atapi_pc request_sense_pc;
+       struct request request_sense_rq;
 
        /* Last error information */
        u8 sense_key, asc, ascq;
@@ -226,29 +218,36 @@ static void ide_floppy_io_buffers(ide_drive_t *drive, struct ide_atapi_pc *pc,
                                  unsigned int bcount, int direction)
 {
        ide_hwif_t *hwif = drive->hwif;
-       struct request *rq = pc->rq;
-       struct req_iterator iter;
-       struct bio_vec *bvec;
-       unsigned long flags;
+       const struct ide_tp_ops *tp_ops = hwif->tp_ops;
+       xfer_func_t *xf = direction ? tp_ops->output_data : tp_ops->input_data;
+       struct scatterlist *sg = pc->sg;
+       char *buf;
        int count, done = 0;
-       char *data;
-
-       rq_for_each_segment(bvec, rq, iter) {
-               if (!bcount)
-                       break;
-
-               count = min(bvec->bv_len, bcount);
-
-               data = bvec_kmap_irq(bvec, &flags);
-               if (direction)
-                       hwif->tp_ops->output_data(drive, NULL, data, count);
-               else
-                       hwif->tp_ops->input_data(drive, NULL, data, count);
-               bvec_kunmap_irq(data, &flags);
 
+       while (bcount) {
+               count = min(sg->length - pc->b_count, bcount);
+               if (PageHighMem(sg_page(sg))) {
+                       unsigned long flags;
+
+                       local_irq_save(flags);
+                       buf = kmap_atomic(sg_page(sg), KM_IRQ0) + sg->offset;
+                       xf(drive, NULL, buf + pc->b_count, count);
+                       kunmap_atomic(buf - sg->offset, KM_IRQ0);
+                       local_irq_restore(flags);
+               } else {
+                       buf = sg_virt(sg);
+                       xf(drive, NULL, buf + pc->b_count, count);
+               }
                bcount -= count;
                pc->b_count += count;
                done += count;
+
+               if (pc->b_count == sg->length) {
+                       if (!--pc->sg_cnt)
+                               break;
+                       pc->sg = sg = sg_next(sg);
+                       pc->b_count = 0;
+               }
        }
 
        idefloppy_end_request(drive, 1, done >> 9);
@@ -289,24 +288,6 @@ static void idefloppy_queue_pc_head(ide_drive_t *drive, struct ide_atapi_pc *pc,
        ide_do_drive_cmd(drive, rq);
 }
 
-static struct ide_atapi_pc *idefloppy_next_pc_storage(ide_drive_t *drive)
-{
-       idefloppy_floppy_t *floppy = drive->driver_data;
-
-       if (floppy->pc_stack_index == IDEFLOPPY_PC_STACK)
-               floppy->pc_stack_index = 0;
-       return (&floppy->pc_stack[floppy->pc_stack_index++]);
-}
-
-static struct request *idefloppy_next_rq_storage(ide_drive_t *drive)
-{
-       idefloppy_floppy_t *floppy = drive->driver_data;
-
-       if (floppy->rq_stack_index == IDEFLOPPY_PC_STACK)
-               floppy->rq_stack_index = 0;
-       return (&floppy->rq_stack[floppy->rq_stack_index++]);
-}
-
 static void ide_floppy_callback(ide_drive_t *drive)
 {
        idefloppy_floppy_t *floppy = drive->driver_data;
@@ -365,12 +346,11 @@ static void idefloppy_create_request_sense_cmd(struct ide_atapi_pc *pc)
  */
 static void idefloppy_retry_pc(ide_drive_t *drive)
 {
-       struct ide_atapi_pc *pc;
-       struct request *rq;
+       struct ide_floppy_obj *floppy = drive->driver_data;
+       struct request *rq = &floppy->request_sense_rq;
+       struct ide_atapi_pc *pc = &floppy->request_sense_pc;
 
        (void)ide_read_error(drive);
-       pc = idefloppy_next_pc_storage(drive);
-       rq = idefloppy_next_rq_storage(drive);
        idefloppy_create_request_sense_cmd(pc);
        idefloppy_queue_pc_head(drive, pc, rq);
 }
@@ -571,7 +551,7 @@ static void idefloppy_create_rw_cmd(idefloppy_floppy_t *floppy,
        memcpy(rq->cmd, pc->c, 12);
 
        pc->rq = rq;
-       pc->b_count = cmd == READ ? 0 : rq->bio->bi_size;
+       pc->b_count = 0;
        if (rq->cmd_flags & REQ_RW)
                pc->flags |= PC_FLAG_WRITING;
        pc->buf = NULL;
@@ -585,7 +565,7 @@ static void idefloppy_blockpc_cmd(idefloppy_floppy_t *floppy,
        idefloppy_init_pc(pc);
        memcpy(pc->c, rq->cmd, sizeof(pc->c));
        pc->rq = rq;
-       pc->b_count = rq->data_len;
+       pc->b_count = 0;
        if (rq->data_len && rq_data_dir(rq) == WRITE)
                pc->flags |= PC_FLAG_WRITING;
        pc->buf = rq->data;
@@ -602,15 +582,17 @@ static ide_startstop_t idefloppy_do_request(ide_drive_t *drive,
                struct request *rq, sector_t block_s)
 {
        idefloppy_floppy_t *floppy = drive->driver_data;
+       ide_hwif_t *hwif = drive->hwif;
        struct ide_atapi_pc *pc;
        unsigned long block = (unsigned long)block_s;
 
-       debug_log("dev: %s, cmd_type: %x, errors: %d\n",
-                       rq->rq_disk ? rq->rq_disk->disk_name : "?",
-                       rq->cmd_type, rq->errors);
-       debug_log("sector: %ld, nr_sectors: %ld, "
-                       "current_nr_sectors: %d\n", (long)rq->sector,
-                       rq->nr_sectors, rq->current_nr_sectors);
+       debug_log("%s: dev: %s, cmd: 0x%x, cmd_type: %x, errors: %d\n",
+                 __func__, rq->rq_disk ? rq->rq_disk->disk_name : "?",
+                 rq->cmd[0], rq->cmd_type, rq->errors);
+
+       debug_log("%s: sector: %ld, nr_sectors: %ld, current_nr_sectors: %d\n",
+                 __func__, (long)rq->sector, rq->nr_sectors,
+                 rq->current_nr_sectors);
 
        if (rq->errors >= ERROR_MAX) {
                if (floppy->failed_pc)
@@ -629,12 +611,12 @@ static ide_startstop_t idefloppy_do_request(ide_drive_t *drive,
                        idefloppy_end_request(drive, 0, 0);
                        return ide_stopped;
                }
-               pc = idefloppy_next_pc_storage(drive);
+               pc = &floppy->queued_pc;
                idefloppy_create_rw_cmd(floppy, pc, rq, block);
        } else if (blk_special_request(rq)) {
                pc = (struct ide_atapi_pc *) rq->buffer;
        } else if (blk_pc_request(rq)) {
-               pc = idefloppy_next_pc_storage(drive);
+               pc = &floppy->queued_pc;
                idefloppy_blockpc_cmd(floppy, pc, rq);
        } else {
                blk_dump_rq_flags(rq,
@@ -643,6 +625,12 @@ static ide_startstop_t idefloppy_do_request(ide_drive_t *drive,
                return ide_stopped;
        }
 
+       ide_init_sg_cmd(drive, rq);
+       ide_map_sg(drive, rq);
+
+       pc->sg = hwif->sg_table;
+       pc->sg_cnt = hwif->sg_nents;
+
        pc->rq = rq;
 
        return idefloppy_issue_pc(drive, pc);
@@ -738,7 +726,7 @@ static int idefloppy_get_sfrp_bit(ide_drive_t *drive)
                return 1;
 
        floppy->srfp = pc.buf[8 + 2] & 0x40;
-       return (0);
+       return 0;
 }
 
 /*
@@ -866,16 +854,17 @@ static int ide_floppy_get_format_capacities(ide_drive_t *drive, int __user *arg)
        int __user *argp;
 
        if (get_user(u_array_size, arg))
-               return (-EFAULT);
+               return -EFAULT;
 
        if (u_array_size <= 0)
-               return (-EINVAL);
+               return -EINVAL;
 
        idefloppy_create_read_capacity_cmd(&pc);
        if (idefloppy_queue_pc_tail(drive, &pc)) {
                printk(KERN_ERR "ide-floppy: Can't get floppy parameters\n");
-               return (-EIO);
+               return -EIO;
        }
+
        header_len = pc.buf[3];
        desc_cnt = header_len / 8; /* capacity descriptor of 8 bytes */
 
@@ -897,19 +886,22 @@ static int ide_floppy_get_format_capacities(ide_drive_t *drive, int __user *arg)
                length = be16_to_cpup((__be16 *)&pc.buf[desc_start + 6]);
 
                if (put_user(blocks, argp))
-                       return(-EFAULT);
+                       return -EFAULT;
+
                ++argp;
 
                if (put_user(length, argp))
-                       return (-EFAULT);
+                       return -EFAULT;
+
                ++argp;
 
                ++u_index;
        }
 
        if (put_user(u_index, arg))
-               return (-EFAULT);
-       return (0);
+               return -EFAULT;
+
+       return 0;
 }
 
 /*
@@ -922,7 +914,7 @@ static int ide_floppy_get_format_capacities(ide_drive_t *drive, int __user *arg)
  * the dsc bit, and return either 0 or 65536.
  */
 
-static int idefloppy_get_format_progress(ide_drive_t *drive, int __user *arg)
+static int ide_floppy_get_format_progress(ide_drive_t *drive, int __user *arg)
 {
        idefloppy_floppy_t *floppy = drive->driver_data;
        struct ide_atapi_pc pc;
@@ -931,7 +923,7 @@ static int idefloppy_get_format_progress(ide_drive_t *drive, int __user *arg)
        if (floppy->srfp) {
                idefloppy_create_request_sense_cmd(&pc);
                if (idefloppy_queue_pc_tail(drive, &pc))
-                       return (-EIO);
+                       return -EIO;
 
                if (floppy->sense_key == 2 &&
                    floppy->asc == 4 &&
@@ -950,10 +942,11 @@ static int idefloppy_get_format_progress(ide_drive_t *drive, int __user *arg)
 
                progress_indication = ((stat & ATA_DSC) == 0) ? 0 : 0x10000;
        }
+
        if (put_user(progress_indication, arg))
-               return (-EFAULT);
+               return -EFAULT;
 
-       return (0);
+       return 0;
 }
 
 static sector_t idefloppy_capacity(ide_drive_t *drive)
@@ -999,7 +992,7 @@ static void idefloppy_setup(ide_drive_t *drive, idefloppy_floppy_t *floppy)
        u8 gcw[2];
 
        *((u16 *)&gcw) = id[ATA_ID_CONFIG];
-       floppy->pc = floppy->pc_stack;
+
        drive->pc_callback = ide_floppy_callback;
 
        if (((gcw[0] & 0x60) >> 5) == 1)
@@ -1227,11 +1220,10 @@ static int ide_floppy_lockdoor(ide_drive_t *drive, struct ide_atapi_pc *pc,
        return 0;
 }
 
-static int ide_floppy_format_unit(idefloppy_floppy_t *floppy,
-                                 int __user *arg)
+static int ide_floppy_format_unit(ide_drive_t *drive, int __user *arg)
 {
+       idefloppy_floppy_t *floppy = drive->driver_data;
        struct ide_atapi_pc pc;
-       ide_drive_t *drive = floppy->drive;
        int blocks, length, flags, err = 0;
 
        if (floppy->openers > 1) {
@@ -1276,6 +1268,24 @@ out:
        return err;
 }
 
+static int ide_floppy_format_ioctl(ide_drive_t *drive, struct file *file,
+                                  unsigned int cmd, void __user *argp)
+{
+       switch (cmd) {
+       case IDEFLOPPY_IOCTL_FORMAT_SUPPORTED:
+               return 0;
+       case IDEFLOPPY_IOCTL_FORMAT_GET_CAPACITY:
+               return ide_floppy_get_format_capacities(drive, argp);
+       case IDEFLOPPY_IOCTL_FORMAT_START:
+               if (!(file->f_mode & 2))
+                       return -EPERM;
+               return ide_floppy_format_unit(drive, (int __user *)argp);
+       case IDEFLOPPY_IOCTL_FORMAT_GET_PROGRESS:
+               return ide_floppy_get_format_progress(drive, argp);
+       default:
+               return -ENOTTY;
+       }
+}
 
 static int idefloppy_ioctl(struct inode *inode, struct file *file,
                        unsigned int cmd, unsigned long arg)
@@ -1287,23 +1297,12 @@ static int idefloppy_ioctl(struct inode *inode, struct file *file,
        void __user *argp = (void __user *)arg;
        int err;
 
-       switch (cmd) {
-       case CDROMEJECT:
-               /* fall through */
-       case CDROM_LOCKDOOR:
+       if (cmd == CDROMEJECT || cmd == CDROM_LOCKDOOR)
                return ide_floppy_lockdoor(drive, &pc, arg, cmd);
-       case IDEFLOPPY_IOCTL_FORMAT_SUPPORTED:
-               return 0;
-       case IDEFLOPPY_IOCTL_FORMAT_GET_CAPACITY:
-               return ide_floppy_get_format_capacities(drive, argp);
-       case IDEFLOPPY_IOCTL_FORMAT_START:
-               if (!(file->f_mode & 2))
-                       return -EPERM;
 
-               return ide_floppy_format_unit(floppy, (int __user *)arg);
-       case IDEFLOPPY_IOCTL_FORMAT_GET_PROGRESS:
-               return idefloppy_get_format_progress(drive, argp);
-       }
+       err = ide_floppy_format_ioctl(drive, file, cmd, argp);
+       if (err != -ENOTTY)
+               return err;
 
        /*
         * skip SCSI_IOCTL_SEND_COMMAND (deprecated)
@@ -1312,8 +1311,6 @@ static int idefloppy_ioctl(struct inode *inode, struct file *file,
        if (cmd != CDROM_SEND_PACKET && cmd != SCSI_IOCTL_SEND_COMMAND)
                err = scsi_cmd_ioctl(file, bdev->bd_disk->queue,
                                        bdev->bd_disk, cmd, argp);
-       else
-               err = -ENOTTY;
 
        if (err == -ENOTTY)
                err = generic_ide_ioctl(drive, file, bdev, cmd, arg);